Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change display when description is too long #9347

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Change display when description is too long #9347

merged 1 commit into from
Oct 21, 2024

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Oct 15, 2024 •
edited by emersion
Loading

@theocrsb theocrsb changed the title front: Change display when description is too long Change display when description is too long Oct 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 39.08%. Comparing base (3ad5d84) to head (7d6f966).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...tudies/components/Scenario/ScenarioDescription.tsx 0.00% 36 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #9347      +/-   ##
============================================
- Coverage     39.11%   39.08%   -0.03%     
  Complexity     2267     2267              
============================================
  Files          1308     1308              
  Lines         99133    99168      +35     
  Branches       3313     3313              
============================================
- Hits          38771    38762       -9     
- Misses        58398    58442      +44     
  Partials       1964     1964
Flag Coverage Δ
core 74.97% <ø> (ø)
editoast 71.98% <ø> (-0.04%) ⬇️
front 10.33% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
osrdyne 3.30% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb force-pushed the tce/front/trainschedule/fix-too-long-description branch 6 times, most recently from 168a3a7 to 398c4c0 Compare October 15, 2024 13:45
@theocrsb theocrsb marked this pull request as ready for review October 15, 2024 13:46
@theocrsb theocrsb requested a review from a team as a code owner October 15, 2024 13:46
Akctarus
Akctarus reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, left few comments.
Also, when the description is open, everything below is shifted.
In the mock-up, this is not the case, the description should covers the divs below.

front/src/applications/operationalStudies/components/Scenario/ScenarioDescription.tsx Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/components/Scenario/ScenarioDescription.tsx Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/components/Scenario/ScenarioDescription.tsx Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/components/Scenario/ScenarioDescription.tsx Outdated Show resolved Hide resolved
@theocrsb
Copy link
Contributor Author

Tested, left few comments. Also, when the description is open, everything below is shifted. In the mock-up, this is not the case, the description should covers the divs below.

I just changed the behavior

Akctarus
Akctarus approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM, just left few comments related to our precedent conversation

front/src/applications/operationalStudies/components/Scenario/ScenarioDescription.tsx Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/components/Scenario/ScenarioDescription.tsx Outdated Show resolved Hide resolved
front/src/applications/operationalStudies/components/Scenario/ScenarioDescription.tsx Outdated Show resolved Hide resolved
@theocrsb theocrsb force-pushed the tce/front/trainschedule/fix-too-long-description branch 2 times, most recently from 1cb5414 to 6791171 Compare October 16, 2024 08:14
@theocrsb theocrsb force-pushed the tce/front/trainschedule/fix-too-long-description branch 3 times, most recently from f7b0861 to 209217e Compare October 21, 2024 08:15
emersion
emersion approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@theocrsb theocrsb force-pushed the tce/front/trainschedule/fix-too-long-description branch from a8cfaac to 9eab852 Compare October 21, 2024 13:23
@theocrsb
front: change display when description is too long
7d6f966 
Signed-off-by: theocrsb <theo_crosbie@yahoo.fr>
@theocrsb theocrsb force-pushed the tce/front/trainschedule/fix-too-long-description branch from 9eab852 to 7d6f966 Compare October 21, 2024 13:29
@theocrsb theocrsb added this pull request to the merge queue Oct 21, 2024
Merged via the queue into dev with commit 67c0a2c Oct 21, 2024
24 checks passed
@theocrsb theocrsb deleted the tce/front/trainschedule/fix-too-long-description branch October 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersion emersion emersion approved these changes

@Akctarus Akctarus Awaiting requested review from Akctarus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theocrsb @codecov-commenter @emersion @Akctarus