Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect data parsing for trending cryptocurrency #41

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

nidhi2026
Copy link
Contributor

This pull request addresses the issue where the "Trending Cryptocurrencies" feature in the Telegram bot was displaying incorrect or "Unknown" data for coin names, symbols, and details. The problem was caused by improper parsing of the CoinGecko API's different formats of responses for trending and top 100 cryptos.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

@Harish-2003
Copy link
Contributor

Screenshot

@nidhi2026
Copy link
Contributor Author

Before change
image

After change
image

@nidhi2026
Copy link
Contributor Author

this pr fixes #38 to fetch cryptocurrencies successfully

@nidhi2026
Copy link
Contributor Author

@Harish-2003
I have added the screenshot as well as referred to the issue

@Harish-2003 Harish-2003 merged commit 2b93620 into OpenTekHub:main Oct 6, 2024
1 check passed
@nidhi2026
Copy link
Contributor Author

@Harish-2003
Thank you for merging
Can you also please label my pr and issue under gssoc-ext and level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants