Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove arrow functions in tests #1202

Closed
nventuro opened this issue Aug 13, 2018 · 0 comments · Fixed by #1225
Closed

Remove arrow functions in tests #1202

nventuro opened this issue Aug 13, 2018 · 0 comments · Fixed by #1225
Labels
good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.
Milestone
v2.0

Comments

@nventuro
Copy link
Contributor

Using arrow functions in Mocha is discouraged. We have some of those in Superuser, ECRecovery, RBAC, and SignatureBouncer: they should be removed.

Part of #1091.
@nventuro nventuro added good first issue Low hanging fruit for new contributors to get involved! kind:improvement tests Test suite and helpers. labels Aug 13, 2018
@nventuro nventuro mentioned this issue Aug 13, 2018
Closed
9 tasks
@jacobherrington jacobherrington mentioned this issue Aug 21, 2018
Merged
3 tasks
@come-maiz come-maiz added this to the v2.0 milestone Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

remove arrow functions from js tests
2 participants
@come-maiz @nventuro