Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not return error when given invalid configuration #17

Open
onematchfox opened this issue Nov 11, 2019 · 0 comments
Open

Plugin does not return error when given invalid configuration #17

onematchfox opened this issue Nov 11, 2019 · 0 comments

Comments

@onematchfox
Copy link

Ran into a little issue the other day. When updating the configuration of some containers, the location of our keys moved, but the configuration of this plugin was not updated. Whilst this plugin, did log the error, to my surprise it still produced a JWT token albeit signed by a certificate that is auto-generated by the LUA openssl library in use. Thus, the issue ultimately only presented itself on the upstreams during token validation.

This goes against the principle of least surprise for me as I would have expected a more outright failure to have occurred. I guess this is a subjective opinion but my expectation would be that the contract between Kong and an upstream that is defined through use of this plugin is a guarantee that the if the request is successfully proxied and a JWT token is added, then it will be valid. Ultimately there is no point in proxying the request if it is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant