Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for user intent before opening wallet #369

Open
micahalcorn opened this issue Jan 30, 2023 · 3 comments
Open

Wait for user intent before opening wallet #369

micahalcorn opened this issue Jan 30, 2023 · 3 comments
Assignees
@HrikB
Labels
enhancement New feature or request P2 Small number of users are affected, major cosmetic issue planned In-scope at the beginning of the sprint ui/ux Workd that requires design and product overview

Comments

@micahalcorn
Copy link
Member

Users should not be hit with a MetaMask prompt immediately when opening our dapps. The Origin Dollar dapp does not prompt the user until she clicks a connect button. This is the way it should be. Currently, I get interrupted by MetaMask when I first load governance.ousd.com, which may only be true because I have connected my account but my MetaMask is locked.

https://www.loom.com/share/79a8c77032e341069d29faa55a028a8c
@micahalcorn micahalcorn added enhancement New feature or request ui/ux Workd that requires design and product overview P2 Small number of users are affected, major cosmetic issue labels Jan 30, 2023
@micahalcorn micahalcorn added this to the Sprint 45 milestone Feb 13, 2023
@franckc
Copy link

franckc commented Feb 16, 2023

Let's try to standardize our wallet connect library across all our sites. Chat with @tomhirst - I think he had tried a few months ago

@franckc franckc modified the milestones: Sprint 45, Sprint 46 Mar 3, 2023
@HrikB HrikB mentioned this issue Mar 3, 2023
Closed
1 task
@micahalcorn micahalcorn added the planned In-scope at the beginning of the sprint label Mar 3, 2023
@franckc franckc modified the milestones: Sprint 46, Sprint 47 Mar 16, 2023
@micahalcorn micahalcorn modified the milestones: Sprint 47, Sprint 48, Sprint 49 Apr 7, 2023
@rafaelugolini
Copy link
Contributor

Let's try to standardize our wallet connect library across all our sites. Chat with @tomhirst - I think he had tried a few months ago

This is the best library out there to connect wallets: https://www.rainbowkit.com/

@tomhirst
Copy link
Contributor

Let's try to standardize our wallet connect library across all our sites. Chat with @tomhirst - I think he had tried a few months ago

This is the best library out there to connect wallets: https://www.rainbowkit.com/

Yeah, I've been banging this drum for a while 😆

@micahalcorn micahalcorn removed this from the Sprint 49 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HrikB HrikB

Labels
enhancement New feature or request P2 Small number of users are affected, major cosmetic issue planned In-scope at the beginning of the sprint ui/ux Workd that requires design and product overview
Projects
Origin DeFi (OUSD + OETH)
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using @web3react/core for wallet sign-in OriginProtocol/ousd-governance
5 participants
@micahalcorn @franckc @rafaelugolini @tomhirst @HrikB