forked from audreyfeldroy/cookiecutter-pypackage
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream changes, use src layout #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The folder "dask-worker-space/" is a cache folder (like "__pycache__/") for IPython/Jupyter or other projects that implement Dask (https://dask.org). If a data science project package uses Jupyter notebooks, there is a chance that they might use Dask. This addition keeps that cache out of commits.
Built off initial work by @goyalyashpal. Co-Authored-By: goyalyashpal <19423063+goyalyashpal@users.noreply.github.com>
…ject.toml Initial working pyproject.toml addition
…les-instead-of-the-plain-commands Document the make rules instead of the plain commands
Add a code of conduct
Create python-publish.yml
Improve the Makefile
Add missing space after -r
fix audreyfeldroy#715: Get tests running + remove obsolete Argparse tests
- adapted to src structure... moved to pathlib
…wine-1.14.0-to-5.0.0 Update twine to 5.0.0
…phinx-1.8.5-to-7.2.6 Update sphinx to 7.2.6
…references-in-makefile remove-black-references-in-makefile
# Conflicts: # cookiecutter.json # hooks/post_gen_project.py # hooks/pre_gen_project.py # requirements_dev.txt # setup.py # tests/test_bake_project.py # tox.ini # {{cookiecutter.project_slug}}/CONTRIBUTING.rst # {{cookiecutter.project_slug}}/Makefile # {{cookiecutter.project_slug}}/pyproject.toml # {{cookiecutter.project_slug}}/requirements_dev.txt # {{cookiecutter.project_slug}}/tests/test_{{cookiecutter.project_slug}}.py # {{cookiecutter.project_slug}}/{{cookiecutter.project_slug}}/cli.py
Zeitsperre
changed the title
Upstream changes, use flat src layout
Upstream changes, use src layout
May 7, 2024
bzah
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, some changes will clash with #38 but nothing too serious.
@bzah I'll merge my changes in here now and see if I can sort out the differences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Yes. The new src layout will have repercussions on all downstream projects.
Other information:
Closes #39
FYI @bzah