Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First day with temperature threshold reached does not benefits from RL improvements #1767

Open
aulemahal opened this issue Jun 5, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@aulemahal
Copy link
Collaborator

aulemahal commented Jun 5, 2024

The generic first_day_temperature_reached does not use rl.resample_and_rl, which make the potential improvments of inverting the operation order inaccessible.

out: xarray.DataArray = cond.resample(time=freq).map(
rl.first_run_after_date,
window=window,
date=after_date,
dim="time",
coord="dayofyear",
)

@aulemahal aulemahal added the enhancement New feature or request label Jun 5, 2024
@aulemahal aulemahal added this to the v0.50.0 milestone Jun 5, 2024
@Zeitsperre Zeitsperre modified the milestones: v0.50.0, Summer 2024 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants