Queue overlaps player controls #951
Comments
|
Cannot reproduce on Sony Xperia 1 V; Android 14
|
Maybe is a Xiaomi HyperOS thing? |
|
Maybe, but I just got a software update, probably to Android 15. I'll try again soon. |
|
Okay, cannot reproduce on Sony Xperia 1 V; Android 15 either. Since it is basically a stock Android experience, it's probably a HyperOS thing
|
|
Yeah, this is a HyperOS regression because it probably broke WindowInsets support at some point for unknown reasons. Nothing I can do but test random in-development builds until the error appears @VoxelPrismatic. |
|
Can you try all of the debug APKs in these ZIP files and report if any of them have the UI bug @gabeweb? Auxio_fc90d46.zip |
Sure, let me try them all out. |
Okay, I tried all the APKs and everything was fine. I noticed that the first version had excessive padding, while the other three did not. The following are the screenshots in the same order as the ZIP list:
|
|
Okay @gabeweb, can you just try the latest debug build? Pretty much all of the major inset changes were done in that version so I need to rule out this being some kind of weird release/debug discrepancy. |
|
Here's the screenshot of Auxio Canary in Android 15/HyperOS 2:
Queue list isn't overlapping the player's controls. |
|
I really don't know what to do here @gabeweb. This is very likely a HyperOS issue triggered only by timing differences between release and debug builds. |
|
When I switch the app's theme (from Dark to Light or vice versa, instead of using Auto), the queue list temporarily overlaps the controls. This only happens immediately after changing the theme. Closing and reopening the app resolves the issue. |
|
And this doesn't occur on any of the other debug builds I provided earlier @gabeweb? |
I can actually reproduce this one |
Let me try. |
|
Please try the debug builds @VoxelPrismatic |
Tested again:
And nothing of them has the issue presented in the Canary version. |
crash infoactions for crash. you must enter a sub-panel.
screen-20250109-145501.mp4If you are able to go back, the app slows horrendously and canary comes to investigate ram leaks |
|
Okay, so it actually seems to be something that occured later in development. Given that this occurred after the window inset changes, my guess is a dependency upgrade broke something @VoxelPrismatic @gabeweb, will get another set of debug builds. |
|
Try this out @gabeweb @VoxelPrismatic Also: The crash you reported is a problem with navigation's predictive back support, it's the reason why I've disabled it. It's just in the commit history I've turned it on and off to see if the bugs have been fixed yet. |
|
Nope. Still breaks after the theme change. And round mode is still enforced. Also, the first time I opened the menu, it crashed.screen-20250109-212521.mp4
Resolves after selecting a track to play. |
I know, its an old debug build I grabbed to reduce the space in which the issue was introduced. Will need to find an older build apparently. |
|
The plot thickens |
|
Commit de36 is still tagged as 4.0.0-dev3 |
de36 is technically part of all of the commits between 3.6.3 and 4.0.0, hence the tag. this is generally where im searching for the bug. |
|
Oh you checkout that commit and build every time. I thought you had some CI/CD that built on every commit. I wish I could help more, but that will take significant time so I can get familiar with the codebase. |
Not really, GitHub does CI/CD on every push and keeps the apk around for a good while before discarding it. Eventually you have to clone and build yourself though, which is annoying. Auxio should mostly be buildable in Android Studio but older revisions require you to sync up the submodules and whatnot. |
I tested the Hacky1 file and everything works fine: no queue list overlapping, changing themes/modes, no crash app when changing setting, and portrait/landscape modes. |
|
If I'm able to analyze your logs I might be able to temporarily hack in a fix @VoxelPrismatic until I presumably give up and finally migrate to Jetpack Compose so I don't have to constantly wrestle with these broken components. |
|
Sorry for the delay. |
|
Okay, so I'm noticing consistent insets being applied, for some reason it's not translating to padding. Here's another hacky attempt to force it. Try this @VoxelPrismatic? Auxio_Hacky3.zip |
|
Does that one have logging enabled? |
Dont think so @VoxelPrismatic |
Video to match logs with actions Still broken |
|
Okay, this is my last ditch attempt to fix this problem @VoxelPrismatic. If this does not work, it's simply unfixable, your OEM has broken your UI elements for some reason, there is nothing I can do until I can throw out this entire thing and hopefully see if Jetpack Compose can do something as fundamental as lay out a view. |
|
It would be funny if Sony broke something considering this is basically stock Android. Still didn't work. screen-20250110-162959.mp4 |
|
Let me try on my Bigme Hibreak, which runs Android 11. There is an update available, I'll get back to you soon. |
|
Yeah, your device refusing to respond to padding updates being executed every frame and me caching the largest inset padding, it's 100% busted @VoxelPrismatic. Going to ship 4.0.0 as-is and assume this is a fringe bug from badly supported devices. Perhaps Jetpack Compose will work. |
|
Out of curiosity, what is your phone? |
|
Pixel 8 @VoxelPrismatic. It's way more stock android than Sony (The changed quick control panel is a dead giveaway Sony has been doing some mods). |
|
I suppose we define "stock" very differently. Sony sticks much closer to AOSP than Google. There are some mods, but 99% of them are Sony related. Eg, there is an equalizer setting that links back to the Sound Connect app, and some Sony camera apps. |
Does not occur here, but it is Android 11 |
|
I see. Still, since there is no way to fix this, the bug is extremely inconsistent, and the surface it occurs is AFAIK very rare, I just have to assume that there is nothing that can be done @VoxelPrismatic. Ill probably put more time if this is a very common issue. |
|
I see. Still, since there is no way to fix this, the bug is extremely inconsistent, and the surface it occurs is AFAIK very rare, I just have to assume that there is nothing that can be done @VoxelPrismatic. Ill probably put more time if this is a very common issue. At most Im going to keep the broken patch in and hope that does something to mitigate it. |
|
I'll keep testing on more devices that I have. I'll let you know what pops up. |
|
Onyx Boox Note 4C (Android 14) - Works as expected |
I'm just wondering why the Android 14 APK works fine, but the Android 15 one does not. What changes between the two? |
|
As far as I am aware @VoxelPrismatic, it's some kind of strange timing difference between either an upgraded dependency or a platform compatibility change. Here is one more last ditch attempt to see what's going on now @VoxelPrismatic, can you take logs on this? Specifically try to filter only logs containing |
Curiously, it stops logging. screen-20250111-110339.mp4 |
|
It might also be logging but with the same information repeatedly @VoxelPrismatic, try this, should log with random numbers to see if its doing anything new |
|
Nope. Stops logging after entering the settings panel. screen-20250111-110845.mp4 |
|
............... @VoxelPrismatic |
|
I think I know what the issue is now @VoxelPrismatic. I think your view never receives WindowInsets once you make that theme change for some inexplicable reason. Log on this so I can tell: In this case, I will need to probably set up a bunch of logging at various WindowInsets locations to see why it's never went. |
|
Anything I should log for specifically? |
|
|
|
Null, curiously. screen-20250111-111753.mp4 |
|
Knew it @VoxelPrismatic, the playback panel never recieves the window insets! But the rest of the app does given that nothing else slides beneath the playback bar or status bars. Will get back later with another build that logs the flow of window insets to see at what point it breaks down. |
Playing whatever, from playlist, album, artist, etc., on the Now playing screen, the queue list overlaps player controls.
However, the lastest stable version (from F-Droid) hasn't that issue but the padding is "too much" (I think):
Redmi Note 13 4G (HyperOS 2.0.4 / Android 15.0)
The text was updated successfully, but these errors were encountered: