Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats_glm.t fails with PDL 2.086 #31

Closed
sebastic opened this issue Apr 4, 2024 · 4 comments
Closed

stats_glm.t fails with PDL 2.086 #31

sebastic opened this issue Apr 4, 2024 · 4 comments

Comments

@sebastic
Copy link
Contributor

sebastic commented Apr 4, 2024

The test suite for the Debian package fails since the update of pdl to 2.086:

 34s Error in PDL::Slatec::gedi: output parameter 'det' implicit dim 1 size 2, can't broadcast over output ndarray with size > 1
 34s  at slatec.pd line 463.
 34s 	PDL::matinv(PDL=SCALAR(0x55aeb5a5fcc0)) called at glm.pd line 766
 34s 	PDL::Stats::GLM::_ols_common(1, PDL=SCALAR(0x55aeb5a5fc30), PDL=SCALAR(0x55aeb5a5fa98)) called at glm.pd line 727
 34s 	PDL::ols_t(PDL=SCALAR(0x55aeb5a5fc30), PDL=SCALAR(0x55aeb5a5fa98)) called at t/stats_glm.t line 54
 34s # Tests were run but no plan was declared and done_testing() was not seen.
 34s # Looks like your test exited with 2 just after 11.
 34s Dubious, test returned 2 (wstat 512, 0x200)

https://ci.debian.net/packages/libp/libpdl-stats-perl/testing/amd64/44766893/

CC: @mohawk2

@mohawk2
Copy link
Member

mohawk2 commented Apr 4, 2024

Thank you. The downstream testing didn't catch that, and I guess that's because it doesn't make sure Fortran is there so Slatec doesn't get built. That's clearly an error in PDL-Stats which I will fix right now. (I'm also adding 32-bit CI to avoid repeats of PDLPorters/pdl#469)

@mohawk2
Copy link
Member

mohawk2 commented Apr 4, 2024

The above-linked commit catches this problem. Now to fix it!

mohawk2 added a commit to PDLPorters/pdl that referenced this issue Apr 4, 2024
@mohawk2
Copy link
Member

mohawk2 commented Apr 4, 2024

@sebastic The above commit fixes this, and an updated PDL will be released soon. Are you happy to close this, since it's not actually a bug in PDL::Stats?

@sebastic
Copy link
Contributor Author

sebastic commented Apr 4, 2024

Sure, I can reopen it if the issue is still present after the update of the pdl package.

@sebastic sebastic closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants