Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create reference document comparing old/new migration methods #11

Open
RaymondFallon opened this issue Dec 14, 2018 · 1 comment
Open
Assignees

Comments

@RaymondFallon
Copy link
Member

RaymondFallon commented Dec 14, 2018

Many PMACS applications will likely move from using the pmacs-rails_sql_views gem to (scenic + this gem). Can we create a document that compares the old migration methods to the new ones exposed by this gem?

Specifically, developers may wish to upgrade their old migration files when upgrading to this gem. Can we give examples of old pmacs-rails_sql_views migrations and new scenic migrations which would produce identical views?

Two corollaries:

  1. Should such a document live in the gem or should we keep that on the PMACS wiki?
  2. Should we link to this document in our 5.1 -> 5.2 Rails upgrade notes.
@barendt
Copy link
Member

barendt commented Jan 4, 2019

We should definitely create a document to help migrate migrations from the old gem to the new one.

  1. I think the document can stick to just the mechanics of the pmacs-rails_sql_views -> scenic transition, so I think it should live in this gem. The other stuff that lives in a migration for one of our apps (CEAL, etc) is all stuff that's separate from the view code and should hopefully not need to be explicitly spelled out in documentation for our developers.
  2. We should definitely link to this document, once it's created, in the 5.1 -> 5.2 upgrade notes.

I'm going to create a pointer in GitLab to this issue so that somebody can pick it up during a hackathon, but you should feel free to claim it, @RaymondFallon, if you're interested.

@talbutt talbutt self-assigned this Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants