Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: data support for scripts in custom launchers #293

Open
manonstreet opened this issue Jan 18, 2024 · 2 comments
Open

[Feature Request]: data support for scripts in custom launchers #293

manonstreet opened this issue Jan 18, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@manonstreet
Copy link

Is your feature request related to a problem?

No response

Feature Request

When working with a custom launcher, the yaml config supports both script and service. When calling service, the data key is passed to the service; however when using script, data is ignored. Scripts support variables in 2 different ways. One way is via service: script.turn_on, which works fine since data is passed in this case. The other option is via calling the script as a service, which I assume is what the script key is doing for firemote. In the latter case, variables are passed as arbitrary KV pairs via data. This currently does not work since data is not passed.

TLDR: Pass data key for both service and script calls.

Additional Comments (optional)

No response

@manonstreet manonstreet added the enhancement New feature or request label Jan 18, 2024
@PRProd
Copy link
Owner

PRProd commented Jan 21, 2024

@manonstreet ~ Thanks for granting my request and repeating yourself by posting over here too. 😄

@PRProd
Copy link
Owner

PRProd commented Jul 8, 2024

@manonstreet ~

Sorry for the lack of communication on my part. I haven't forgotten about this, just been busy with other things. I still want to implement your ideas. Thanks for your patience and understanding.

-Doug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants