Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[knitr engine] Use prql as code block name #115

Open
eitsupi opened this issue Mar 16, 2023 · 1 comment
Open

[knitr engine] Use prql as code block name #115

eitsupi opened this issue Mar 16, 2023 · 1 comment
Labels
enhancement New feature or request upstream

Comments

@eitsupi
Copy link
Member

eitsupi commented Mar 16, 2023

Currently, the code block for prql is converted to elm.
This is because prql is not considered a valid language by Pandoc.

https://github.com/eitsupi/prqlr/blob/61b207365f0101326ebdbe70d2e364a33a1cf2dd/R/knitr-engine.R#L21-L26

When a prql is registered in Pandoc (and the upstream KDE syntax highlighting), these lines can be deleted.

https://github.com/jgm/skylighting#adding-new-syntaxes
https://github.com/KDE/syntax-highlighting
@eitsupi eitsupi added enhancement New feature or request upstream labels Mar 16, 2023
@eitsupi
Copy link
Member Author

eitsupi commented Mar 17, 2023

Upstream issue PRQL/prql#2213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eitsupi