Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Principled IOR mismatch #16

Open
PearCoding opened this issue Feb 3, 2022 · 2 comments
Open

Principled IOR mismatch #16

PearCoding opened this issue Feb 3, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@PearCoding
Copy link
Owner

The ior from the principled bsdf (aka. disney bsdf) does not work for all ior values. IOR=1 returns just black
@PearCoding PearCoding added the bug Something isn't working label Feb 3, 2022
@pgrit
Copy link
Collaborator

pgrit commented Feb 3, 2022

IOR=1 is a NaN causing corner-case for microfacet distributions. Because there's no such thing as a rough yet non-existent interface between two media ;)

You could add a special case that switches to a non-rough dielectric, or simply enforce a lower bound of 1.00001 or sth.

@PearCoding
Copy link
Owner Author

True, but the behavior is inconsistent in the implementation. The rough dielectric bsdf has no problem dealing with it... the principled bsdf however does. So there is a "happy accident" somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PearCoding @pgrit