Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete Code in met2CF.R #3289

Closed
Sweetdevil144 opened this issue May 7, 2024 · 1 comment · Fixed by #3290
Closed

Incomplete Code in met2CF.R #3289

Sweetdevil144 opened this issue May 7, 2024 · 1 comment · Fixed by #3290

Comments

@Sweetdevil144
Copy link
Contributor

Bug Description

The active file met2CF.R is incomplete. Some variables are not defined and the function dbfile.input.insert is not completed.

The code file was last changed 10 years ago.

To Reproduce

Steps to reproduce the behavior:

  1. Open the file modules/data.atmosphere/inst/scripts/met2CF.R
  2. Scroll down to lines 54
  3. Observe the incomplete code

Expected behavior

The file met2CF.R should contain complete R code. It is observed that the end code block is missing as follow :

  # insert into db as input
dbfile.input.insert <- function(filename, siteid, startdate, enddate, mimetype, formatname, con, hostname=PEcAn.remote::fqdn()) {

Screenshots

Screenshot 2024-05-07 at 4 19 24 PM

If applicable, add screenshots to help explain your problem.

Machine (please complete the following information):

  • Server: NaN
  • OS: MacOS
  • Version:

Additional context

The incomplete code may be causing issues with the execution of the program. The missing variables and incomplete function need to be defined and completed respectively.

@mdietze
Copy link
Member

mdietze commented May 7, 2024

This script isn't used and can be deleted. Has been superseded by met2CF.csv.R and met2CF.nc.R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants