Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed addresses bugs & minor improvements #326

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Fixed addresses bugs & minor improvements #326

merged 5 commits into from
Jul 17, 2024

Conversation

ArtemBurakov
Copy link
Contributor

No description provided.

rileystephens28
rileystephens28 reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@rileystephens28 rileystephens28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Only think I noticed is that ethers is still a dependency depsite removing all the sub packages. Is it worth the lift to remove ethers as a dependency in this PR as well?

@rileystephens28 rileystephens28 merged commit fd6d562 into PelagusWallet:main Jul 17, 2024
@ArtemBurakov ArtemBurakov deleted the migration branch July 19, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileystephens28 rileystephens28 rileystephens28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArtemBurakov @rileystephens28 @MichaelKostroma