-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dapp and custom assets #374
Merged
rileystephens28
merged 10 commits into
PelagusWallet:1.0
from
ArtemBurakov:refactor-dapp-custom-assets
Oct 8, 2024
Merged
Refactor dapp and custom assets #374
rileystephens28
merged 10 commits into
PelagusWallet:1.0
from
ArtemBurakov:refactor-dapp-custom-assets
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ArtemBurakov
commented
Sep 27, 2024
- fixed bugs related to dApp interactions, including issues with the send transaction pop-up after user interactions.
- resolved bugs when adding custom assets, with updates to handle incorrect BigInt fields.
- updated and fixed the signTypedData function in the internal Quai provider.
ArtemBurakov
force-pushed
the
refactor-dapp-custom-assets
branch
from
September 27, 2024 16:55
d45dbe5
to
a724724
Compare
rileystephens28
approved these changes
Sep 30, 2024
rileystephens28
approved these changes
Sep 30, 2024
…s send transaction instead of sign transaction
MichaelKostroma
force-pushed
the
refactor-dapp-custom-assets
branch
from
October 1, 2024 14:21
6dd0ac2
to
f0e2aea
Compare
rileystephens28
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.