Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Search does not work on Elegant 5.4.0 and Pelican 4.7.1 #789

Open
1 of 3 tasks
silverhook opened this issue Dec 29, 2021 · 11 comments
Open
1 of 3 tasks

[BUG] Search does not work on Elegant 5.4.0 and Pelican 4.7.1 #789

silverhook opened this issue Dec 29, 2021 · 11 comments
Labels
bug Well, it shouldn’t be doing that. Let’s fix it!

Comments

@silverhook
Copy link
Member

Mandatory Step

  • I am using latest production release of Elegant

Recommended Step

  • I have attached link to my blog source code repository, so that developers can try to reproduce the issue at the end
  • I can't my source code but I have linked my pelican configuration files to help developers reproduce the issue

Description

Describe the bug

Search does not work any more. For an example with screenshots see #788.

Pages I already identified do not work right now:

Interestingly enough, @talha131 ’s homepage works:
https://www.oncrashreboot.com/

To Reproduce
Steps to reproduce the behavior:

  1. Enter text into the search bar
  2. Press Enter or click the search button
  3. See empty page, not even an error notice

Expected behavior
List of search results, as before

Screenshots

see #788

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Firefox
  • Version: 95.0.2

Additional context

Relevant issue/comment: #628 (comment)

https://blog.getpelican.com/pelican-4.5-released.html

tipue_search is now deprecated in Pelican in favour of search (which uses Stork).

@silverhook silverhook added the bug Well, it shouldn’t be doing that. Let’s fix it! label Dec 29, 2021
@iranzo
Copy link
Member

iranzo commented Dec 29, 2021

I don't like the 'download stork' approach for this tbh :/

@silverhook
Copy link
Member Author

We could still continue to roll our own, but then it needs to work. It currently doesn’t.

I don’t have strong feelings one way or another which solution is better suited, as long as it’s lean enough to run on my ARM server and works 😸

@rednafi
Copy link

rednafi commented Jan 14, 2022

I'm seeing the same issue as well. As long as there's a documented way of doing things, I'm not too opinionated about the implementation details. If stork is the way to go, can we at least have some elegant theme-specific instructions on how to achieve that?

@justinmayer
Copy link

@iranzo said:

I don't like the 'download stork' approach for this tbh :/

I agree that extra step is cumbersome, but in my estimation the trade-off is well worth it. Stork is written in Rust and is therefore very fast, and above all, it is well-supported by the author.

To me, the more salient question is, "What are the alternatives?" I don't think a long-abandoned and unmaintained project is a sustainable solution, and I don't see a queue of folks lining up to identify, evaluate, select, and implement a viable alternative that provides search functionality.

If you want to see the user experience for yourself, you can see the new Stork-powered Search plugin in action at:

@FrederikLauber
Copy link

Any news on this?
Trying to port an old jekyll site to pelican with elegant and the stork based search does not yet seem to work nor can I find any documentation to fix this.

@justinmayer
Copy link

Hi @FrederikLauber. I can empathize with your desire to achieve your desired outcome. That said, please refer to: “Any Updates?”

@FrederikLauber
Copy link

@justinmayer thanks for your reply. Your link was very enlightening. I figured it out myself besides some graphic issues.

@silverhook
Copy link
Member Author

@FrederikLauber, care to share more?

Search would be nice to have.

@FrederikLauber
Copy link

@silverhook

I pushed my changes here: https://github.com/FrederikLauber/elegant

Probably not good enough for a merge request as I have no clue what I may have broken in the process but it produces a workign search.

@silverhook
Copy link
Member Author

@FrederikLauber is this your website, so I can see how the search works there?

https://flambda.de/

@FrederikLauber
Copy link

Yes it is. The design is the one from the git repo and then I just use some plugins for pelican.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Well, it shouldn’t be doing that. Let’s fix it!
Development

No branches or pull requests

5 participants