From e528fae56a10cf30eee01fd96ee9ce686cfca351 Mon Sep 17 00:00:00 2001 From: Joey Carter Date: Thu, 14 Nov 2024 11:50:24 -0500 Subject: [PATCH] [no ci] Update comment about ".so" suffix --- runtime/lib/backend/openqasm/CMakeLists.txt | 4 ++-- runtime/lib/registry/CMakeLists.txt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/runtime/lib/backend/openqasm/CMakeLists.txt b/runtime/lib/backend/openqasm/CMakeLists.txt index ac0dcc8267..daa887d3f2 100644 --- a/runtime/lib/backend/openqasm/CMakeLists.txt +++ b/runtime/lib/backend/openqasm/CMakeLists.txt @@ -43,8 +43,8 @@ find_package(nanobind CONFIG REQUIRED) nanobind_add_module(openqasm_python_module STABLE_ABI openqasm_python_module.cpp) # Use a consistant suffix ".so" rather than, e.g. ".abi3.so" (when using the Stable ABI) or -# ".cpython-3xx-darwin.so". This ensures we can locate it when calling `dlopen(OPENQASM_PY)` in -# runtime/lib/backend/openqasm/OpenQasmRunner.hpp. +# ".cpython-3xx-darwin.so". Doing so simplifies the process to locate it when calling +# `dlopen(OPENQASM_PY)` in runtime/lib/backend/openqasm/OpenQasmRunner.hpp. set_target_properties(openqasm_python_module PROPERTIES SUFFIX ".so") add_library(rtd_openqasm SHARED OpenQasmDevice.cpp) diff --git a/runtime/lib/registry/CMakeLists.txt b/runtime/lib/registry/CMakeLists.txt index da28c9f6db..380bcd287d 100644 --- a/runtime/lib/registry/CMakeLists.txt +++ b/runtime/lib/registry/CMakeLists.txt @@ -38,8 +38,8 @@ set(REGISTRY_SRC_FILES nanobind_add_module(catalyst_callback_registry STABLE_ABI ${REGISTRY_SRC_FILES}) # Use a consistant suffix ".so" rather than, e.g. ".abi3.so" (when using the Stable ABI) or -# ".cpython-3xx-darwin.so". This ensures we can locate it when calling `dlopen(LIBREGISTRY)` in -# runtime/lib/capi/RuntimeCAPI.cpp. +# ".cpython-3xx-darwin.so". Doing so simplifies the process to locate it when calling +# `dlopen(LIBREGISTRY)` in runtime/lib/capi/RuntimeCAPI.cpp. set_target_properties(catalyst_callback_registry PROPERTIES SUFFIX ".so") target_include_directories(catalyst_callback_registry PUBLIC ${runtime_includes})