From 0237e48b6bf2c201ef7402791c259005c00c8200 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Wed, 4 Sep 2024 17:47:00 -0400 Subject: [PATCH 01/82] Enable warnings as errors globally in test suite --- tests/pytest.ini | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/tests/pytest.ini b/tests/pytest.ini index 1897c3c65e4..8ab74a1ea72 100644 --- a/tests/pytest.ini +++ b/tests/pytest.ini @@ -19,12 +19,5 @@ markers = logging: marks tests for pennylane logging external: marks tests that require external packages such as matplotlib and PyZX catalyst: marks tests for catalyst testing (select with '-m "catalyst"') -filterwarnings = - ignore::DeprecationWarning:autograd.numpy.numpy_wrapper - ignore:Casting complex values to real::autograd.numpy.numpy_wrapper - ignore:Casting complex values to real discards the imaginary part:UserWarning:torch.autograd - ignore:Call to deprecated create function:DeprecationWarning - ignore:the imp module is deprecated:DeprecationWarning - error::pennylane.PennyLaneDeprecationWarning -addopts = --benchmark-disable +addopts = -W error --benchmark-disable xfail_strict=true From 124c444c5b66108a0fe598262e1ca2c3632a5e5d Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Wed, 4 Sep 2024 17:52:12 -0400 Subject: [PATCH 02/82] Ensure all warnings are errors in devices --- pennylane/devices/tests/pytest.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pennylane/devices/tests/pytest.ini b/pennylane/devices/tests/pytest.ini index ba9755e1ca8..626afb21730 100644 --- a/pennylane/devices/tests/pytest.ini +++ b/pennylane/devices/tests/pytest.ini @@ -1,4 +1,4 @@ [pytest] markers = skip_unsupported: skip a test if it uses an operation unsupported on a device -addopts = --benchmark-disable \ No newline at end of file +addopts = -W error --benchmark-disable From 261e6b1fcab8dfcc1e3be5b1a0333d97409cd2c2 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 15:53:18 -0400 Subject: [PATCH 03/82] Add nightly run warnings as errors tests --- .github/workflows/interface-unit-tests.yml | 17 +++++++++++++ .../workflows/package_warnings_as_errors.yml | 25 +++++++++++++++++++ .github/workflows/unit-test.yml | 6 +++++ 3 files changed, 48 insertions(+) create mode 100644 .github/workflows/package_warnings_as_errors.yml diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 601e762fc92..c1990529a96 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -47,6 +47,11 @@ on: required: false type: boolean default: false + python_warning_level: + description: Sets the default Python warning level as defined by https://docs.python.org/3/using/cmdline.html#envvar-PYTHONWARNINGS + required: true + type: string + default: 'default' jobs: setup-ci-load: @@ -168,6 +173,7 @@ jobs: pytest_markers: torch and not qcut and not finite-diff and not param-shift requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'torch.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} autograd-tests: @@ -200,6 +206,7 @@ jobs: pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: autograd and not qcut and not finite-diff and not param-shift disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} tf-tests: @@ -238,6 +245,7 @@ jobs: additional_pip_packages: pytest-split requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'tf.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} jax-tests: @@ -276,6 +284,7 @@ jobs: additional_pip_packages: pytest-split requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'jax.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} core-tests: @@ -314,6 +323,7 @@ jobs: additional_pip_packages: pytest-split requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'core.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} all-interfaces-tests: @@ -347,6 +357,7 @@ jobs: pytest_markers: all_interfaces requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'all_interfaces.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} external-libraries-tests: @@ -386,6 +397,7 @@ jobs: additional_pip_packages: pyzx matplotlib stim quimb mitiq pennylane-qiskit ply requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'external.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} qcut-tests: @@ -419,6 +431,7 @@ jobs: pytest_markers: qcut additional_pip_packages: kahypar==1.1.7 opt_einsum disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} qchem-tests: @@ -452,6 +465,7 @@ jobs: pytest_markers: qchem additional_pip_packages: openfermionpyscf basis-set-exchange disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} gradients-tests: needs: @@ -486,6 +500,7 @@ jobs: pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: ${{ matrix.config.suite }} disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} data-tests: @@ -519,6 +534,7 @@ jobs: pytest_markers: data additional_pip_packages: h5py disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} device-tests: @@ -559,6 +575,7 @@ jobs: pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_additional_args: --device=${{ matrix.config.device }} --shots=${{ matrix.config.shots }} disable_new_opmath: ${{ inputs.disable_new_opmath }} + python_warning_level: ${{ inputs.python_warning_level }} upload-to-codecov: diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml new file mode 100644 index 00000000000..e4eff694e86 --- /dev/null +++ b/.github/workflows/package_warnings_as_errors.yml @@ -0,0 +1,25 @@ +name: Test-suite with warnings as error +on: + # Scheduled trigger every Sunday at 2:35am UTC + schedule: + - cron: '35 2 * * 0' + workflow_dispatch: + +concurrency: + group: unit-tests-${{ github.ref }} + cancel-in-progress: true + +env: + DURATIONS_BRANCH: bot/durations-update + +jobs: + test-warnings-as-errors: + uses: ./.github/workflows/interface-unit-tests.yml + secrets: + codecov_token: ${{ secrets.CODECOV_TOKEN }} + with: + branch: ${{ github.ref }} + pipeline_mode: 'warnings-as-errors' + run_lightened_ci: false + skip_ci_test_jobs: 'qcut-tests' + python_warning_level: 'error' \ No newline at end of file diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 8e11cf86473..36d90ad266f 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -114,6 +114,11 @@ on: required: false type: string default: "False" + python_warning_level: + description: Sets the default Python warning level as defined by https://docs.python.org/3/using/cmdline.html#envvar-PYTHONWARNINGS + required: true + type: string + default: 'default' jobs: test: @@ -187,6 +192,7 @@ jobs: - name: Run PennyLane Unit Tests if: steps.continue.outputs.confirm == 'true' env: + PYTHONWARNINGS: ${{ inputs.python_warning_level }} PYTEST_MARKER: ${{ inputs.pytest_markers != '' && format('-m "{0}"', inputs.pytest_markers) || '' }} COV_CORE_SOURCE: pennylane COV_CORE_CONFIG: .coveragerc From c7ecbe46ddf2a9478fd93c6327790fdf370fcdf1 Mon Sep 17 00:00:00 2001 From: Lee James O'Riordan Date: Thu, 12 Sep 2024 15:54:59 -0400 Subject: [PATCH 04/82] Update pennylane/devices/tests/pytest.ini --- pennylane/devices/tests/pytest.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pennylane/devices/tests/pytest.ini b/pennylane/devices/tests/pytest.ini index 626afb21730..7444d17af76 100644 --- a/pennylane/devices/tests/pytest.ini +++ b/pennylane/devices/tests/pytest.ini @@ -1,4 +1,4 @@ [pytest] markers = skip_unsupported: skip a test if it uses an operation unsupported on a device -addopts = -W error --benchmark-disable +addopts = --benchmark-disable From 6c824a7c2d9bc586b5ec959c44b2701e1877b15b Mon Sep 17 00:00:00 2001 From: Lee James O'Riordan Date: Thu, 12 Sep 2024 15:55:05 -0400 Subject: [PATCH 05/82] Update tests/pytest.ini --- tests/pytest.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/pytest.ini b/tests/pytest.ini index 8ab74a1ea72..4e375b4960d 100644 --- a/tests/pytest.ini +++ b/tests/pytest.ini @@ -19,5 +19,5 @@ markers = logging: marks tests for pennylane logging external: marks tests that require external packages such as matplotlib and PyZX catalyst: marks tests for catalyst testing (select with '-m "catalyst"') -addopts = -W error --benchmark-disable +addopts = --benchmark-disable xfail_strict=true From 23a97658cb25dd0b4784b609486f90540788716a Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 15:58:37 -0400 Subject: [PATCH 06/82] Update CL --- doc/releases/changelog-dev.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/releases/changelog-dev.md b/doc/releases/changelog-dev.md index 2f0eeee194f..a3203d746ae 100644 --- a/doc/releases/changelog-dev.md +++ b/doc/releases/changelog-dev.md @@ -85,6 +85,9 @@

Documentation 📝

+* Add reporting of test warnings as failures. + [(#6217)](https://github.com/PennyLaneAI/pennylane/pull/6217) +

Bug fixes 🐛

* Fix a bug where zero-valued JVPs were calculated wrongly in the presence of shot vectors. From 85d6a4d87ddd5ca39a263ddf19f1b7b992ba49cc Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 17:03:25 -0400 Subject: [PATCH 07/82] Required to false for python warning env var --- .github/workflows/interface-unit-tests.yml | 2 +- .github/workflows/unit-test.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index c1990529a96..0dd8386d96d 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -49,7 +49,7 @@ on: default: false python_warning_level: description: Sets the default Python warning level as defined by https://docs.python.org/3/using/cmdline.html#envvar-PYTHONWARNINGS - required: true + required: false type: string default: 'default' diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 36d90ad266f..9e3aaca0e37 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -116,7 +116,7 @@ on: default: "False" python_warning_level: description: Sets the default Python warning level as defined by https://docs.python.org/3/using/cmdline.html#envvar-PYTHONWARNINGS - required: true + required: false type: string default: 'default' From 55aa823a4d636469d957a9e50b2fd3ba830c63c4 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 17:17:49 -0400 Subject: [PATCH 08/82] Remove pipeline from yml and add PR dispatch --- .github/workflows/package_warnings_as_errors.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index e4eff694e86..71011e6ab54 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -1,25 +1,19 @@ -name: Test-suite with warnings as error +name: Test-suite with Python warnings as errors on: # Scheduled trigger every Sunday at 2:35am UTC schedule: - cron: '35 2 * * 0' workflow_dispatch: + pull_request: concurrency: - group: unit-tests-${{ github.ref }} + group: warnings-as-errors-tests-${{ github.ref }} cancel-in-progress: true -env: - DURATIONS_BRANCH: bot/durations-update - jobs: test-warnings-as-errors: uses: ./.github/workflows/interface-unit-tests.yml - secrets: - codecov_token: ${{ secrets.CODECOV_TOKEN }} with: branch: ${{ github.ref }} - pipeline_mode: 'warnings-as-errors' - run_lightened_ci: false skip_ci_test_jobs: 'qcut-tests' python_warning_level: 'error' \ No newline at end of file From ccdeef88725766ad495796a01410fbec71fc8f92 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 17:20:46 -0400 Subject: [PATCH 09/82] Readd error from warning to all CI runs --- tests/pytest.ini | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/pytest.ini b/tests/pytest.ini index 4e375b4960d..7c99b8c09ca 100644 --- a/tests/pytest.ini +++ b/tests/pytest.ini @@ -21,3 +21,5 @@ markers = catalyst: marks tests for catalyst testing (select with '-m "catalyst"') addopts = --benchmark-disable xfail_strict=true +filterwarnings = + error::pennylane.PennyLaneDeprecationWarning \ No newline at end of file From a904d481596b7ee644637eef77427a026f56b20e Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 17:23:49 -0400 Subject: [PATCH 10/82] Readd missing secrets --- .github/workflows/package_warnings_as_errors.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 71011e6ab54..71de7a59b44 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -13,7 +13,10 @@ concurrency: jobs: test-warnings-as-errors: uses: ./.github/workflows/interface-unit-tests.yml + secrets: + codecov_token: ${{ secrets.CODECOV_TOKEN }} with: + token: ${{ secrets.codecov_token }} branch: ${{ github.ref }} skip_ci_test_jobs: 'qcut-tests' python_warning_level: 'error' \ No newline at end of file From 37fd0cf0aee0f0765585bbcba2d468591d8da90c Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 17:27:13 -0400 Subject: [PATCH 11/82] Readd missing secrets again --- .github/workflows/package_warnings_as_errors.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 71de7a59b44..38b56dfc8a8 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -13,10 +13,8 @@ concurrency: jobs: test-warnings-as-errors: uses: ./.github/workflows/interface-unit-tests.yml - secrets: - codecov_token: ${{ secrets.CODECOV_TOKEN }} with: - token: ${{ secrets.codecov_token }} + token: ${{ secrets.CODECOV_TOKEN }} branch: ${{ github.ref }} skip_ci_test_jobs: 'qcut-tests' python_warning_level: 'error' \ No newline at end of file From 07b1f6c93ffbb758b19a5ea06b333d62d82d0915 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 17:27:13 -0400 Subject: [PATCH 12/82] Readd missing secrets again --- .github/workflows/package_warnings_as_errors.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 71de7a59b44..38b56dfc8a8 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -13,10 +13,8 @@ concurrency: jobs: test-warnings-as-errors: uses: ./.github/workflows/interface-unit-tests.yml - secrets: - codecov_token: ${{ secrets.CODECOV_TOKEN }} with: - token: ${{ secrets.codecov_token }} + token: ${{ secrets.CODECOV_TOKEN }} branch: ${{ github.ref }} skip_ci_test_jobs: 'qcut-tests' python_warning_level: 'error' \ No newline at end of file From 0dd65a71aae9f0589b70b7bdeb4d5813c6cea3c3 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 17:28:15 -0400 Subject: [PATCH 13/82] Cancel CI [skip-ci] From 80292eb5974b42f8dcb97f4e34929f761d0a4a4c Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 17:29:17 -0400 Subject: [PATCH 14/82] Remove secrets --- .github/workflows/package_warnings_as_errors.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 38b56dfc8a8..71011e6ab54 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -14,7 +14,6 @@ jobs: test-warnings-as-errors: uses: ./.github/workflows/interface-unit-tests.yml with: - token: ${{ secrets.CODECOV_TOKEN }} branch: ${{ github.ref }} skip_ci_test_jobs: 'qcut-tests' python_warning_level: 'error' \ No newline at end of file From 00a9e1c1a26f52a25a43599f6c9e93f7eb5190ef Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 17:32:00 -0400 Subject: [PATCH 15/82] Migrate location again --- .github/workflows/package_warnings_as_errors.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 71011e6ab54..0751ef58add 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -13,6 +13,8 @@ concurrency: jobs: test-warnings-as-errors: uses: ./.github/workflows/interface-unit-tests.yml + secrets: + codecov_token: ${{ secrets.CODECOV_TOKEN }} with: branch: ${{ github.ref }} skip_ci_test_jobs: 'qcut-tests' From bb104c11d5e2eede273e68930619619d14063539 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 12 Sep 2024 17:48:42 -0400 Subject: [PATCH 16/82] Disable fail-fast for runs --- .github/workflows/package_warnings_as_errors.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 0751ef58add..a8fc5e2d0d3 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -13,6 +13,8 @@ concurrency: jobs: test-warnings-as-errors: uses: ./.github/workflows/interface-unit-tests.yml + strategy: + fail-fast: false secrets: codecov_token: ${{ secrets.CODECOV_TOKEN }} with: From eccbf9afa45f678c3fd779d3a9292cda1809b79c Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 09:01:22 -0400 Subject: [PATCH 17/82] Migate env-var to inline warning for pytest --- .github/workflows/unit-test.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 9e3aaca0e37..4818e0bb6eb 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -192,14 +192,13 @@ jobs: - name: Run PennyLane Unit Tests if: steps.continue.outputs.confirm == 'true' env: - PYTHONWARNINGS: ${{ inputs.python_warning_level }} PYTEST_MARKER: ${{ inputs.pytest_markers != '' && format('-m "{0}"', inputs.pytest_markers) || '' }} COV_CORE_SOURCE: pennylane COV_CORE_CONFIG: .coveragerc COV_CORE_DATAFILE: .coverage.eager TF_USE_LEGACY_KERAS: "1" # sets to use tf-keras (Keras2) instead of keras (Keras3) when running TF tests # Calling PyTest by invoking Python first as that adds the current directory to sys.path - run: python -m pytest ${{ inputs.pytest_test_directory }} ${{ steps.pytest_args.outputs.args }} ${{ env.PYTEST_MARKER }} --disable-opmath=${{ inputs.disable_new_opmath }} + run: python -m pytest -w ${{ inputs.python_warning_level }} ${{ inputs.pytest_test_directory }} ${{ steps.pytest_args.outputs.args }} ${{ env.PYTEST_MARKER }} --disable-opmath=${{ inputs.disable_new_opmath }} - name: Upload Durations file as artifact if: ${{ inputs.pytest_store_durations == true }} From 15417e87617f2dad7b83571cace18966e69ab8a1 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 09:06:58 -0400 Subject: [PATCH 18/82] Change warning capitalization --- .github/workflows/unit-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 4818e0bb6eb..15d5a30298c 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -198,7 +198,7 @@ jobs: COV_CORE_DATAFILE: .coverage.eager TF_USE_LEGACY_KERAS: "1" # sets to use tf-keras (Keras2) instead of keras (Keras3) when running TF tests # Calling PyTest by invoking Python first as that adds the current directory to sys.path - run: python -m pytest -w ${{ inputs.python_warning_level }} ${{ inputs.pytest_test_directory }} ${{ steps.pytest_args.outputs.args }} ${{ env.PYTEST_MARKER }} --disable-opmath=${{ inputs.disable_new_opmath }} + run: python -m pytest -W ${{ inputs.pytest_test_directory }} ${{ steps.pytest_args.outputs.args }} ${{ env.PYTEST_MARKER }} --disable-opmath=${{ inputs.disable_new_opmath }} - name: Upload Durations file as artifact if: ${{ inputs.pytest_store_durations == true }} From 4591c1b689cd3db360e93c35bcf8cc28b055ec05 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 09:09:06 -0400 Subject: [PATCH 19/82] Once more with env var inclusion --- .github/workflows/unit-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 15d5a30298c..0399af95621 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -198,7 +198,7 @@ jobs: COV_CORE_DATAFILE: .coverage.eager TF_USE_LEGACY_KERAS: "1" # sets to use tf-keras (Keras2) instead of keras (Keras3) when running TF tests # Calling PyTest by invoking Python first as that adds the current directory to sys.path - run: python -m pytest -W ${{ inputs.pytest_test_directory }} ${{ steps.pytest_args.outputs.args }} ${{ env.PYTEST_MARKER }} --disable-opmath=${{ inputs.disable_new_opmath }} + run: python -m pytest -W ${{ inputs.python_warning_level }} ${{ inputs.pytest_test_directory }} ${{ steps.pytest_args.outputs.args }} ${{ env.PYTEST_MARKER }} --disable-opmath=${{ inputs.disable_new_opmath }} - name: Upload Durations file as artifact if: ${{ inputs.pytest_store_durations == true }} From 872e2677268df895292c5a876a6e2fa7fa57562e Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 09:55:37 -0400 Subject: [PATCH 20/82] reduce concurrent workers --- .github/workflows/package_warnings_as_errors.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index a8fc5e2d0d3..e8be2af6ee5 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -15,9 +15,12 @@ jobs: uses: ./.github/workflows/interface-unit-tests.yml strategy: fail-fast: false + max-parallel: 1 secrets: codecov_token: ${{ secrets.CODECOV_TOKEN }} with: branch: ${{ github.ref }} skip_ci_test_jobs: 'qcut-tests' - python_warning_level: 'error' \ No newline at end of file + python_warning_level: 'error' + pytest_durations_file_path: '' + pytest_store_durations: false \ No newline at end of file From 0e70c30f88f2b4393821c9ab6b72af3bab53cdde Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 09:58:17 -0400 Subject: [PATCH 21/82] Remove durations --- .github/workflows/package_warnings_as_errors.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index e8be2af6ee5..e16cd3ee69c 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -22,5 +22,4 @@ jobs: branch: ${{ github.ref }} skip_ci_test_jobs: 'qcut-tests' python_warning_level: 'error' - pytest_durations_file_path: '' - pytest_store_durations: false \ No newline at end of file + \ No newline at end of file From a4d90e3e60de4c4728b5a51fe9bd81e23458c265 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 10:10:30 -0400 Subject: [PATCH 22/82] Remove splitting from warning CI --- .github/workflows/package_warnings_as_errors.yml | 1 + .github/workflows/unit-test.yml | 8 +++++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index e16cd3ee69c..659969bdb88 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -22,4 +22,5 @@ jobs: branch: ${{ github.ref }} skip_ci_test_jobs: 'qcut-tests' python_warning_level: 'error' + pipeline_mode: 'warnings' \ No newline at end of file diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 0399af95621..f7d7d80e01a 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -25,7 +25,7 @@ on: type: string default: '3.10' pipeline_mode: - description: The pipeline mode can be unit-tests, benchmarks, or reference-benchmark + description: The pipeline mode can be unit-tests, benchmarks, reference-benchmark, or warnings required: false type: string default: 'unit-tests' @@ -134,7 +134,7 @@ jobs: repository: PennyLaneAI/pennylane - name: Determine benchmark name - if: ${{ inputs.pipeline_mode != 'unit-tests' }} + if: ${{ inputs.pipeline_mode =~ .*"benchmarks".* }} id: benchmark_name run: | job_name="${{ inputs.job_name }}" @@ -143,7 +143,7 @@ jobs: echo "benchmark_name=$_benchmark_name" >> $GITHUB_OUTPUT - name: Cache reference benchmarks - if: ${{ inputs.pipeline_mode != 'unit-tests' }} + if: ${{ inputs.pipeline_mode =~ .*"benchmarks".* }} id: benchmark-cache uses: actions/cache@v3 with: @@ -185,6 +185,8 @@ jobs: run: | if [[ "$PIPELINE_MODE" =~ .*"benchmarks".* ]]; then echo "args=$PYTEST_BENCHMARKS_ARGS $PYTEST_ADDITIONAL_ARGS" >> $GITHUB_OUTPUT + elif [[ "$PIPELINE_MODE" =~ .*"warnings".* ]]; then + echo "args=$PYTEST_ADDITIONAL_ARGS" >> $GITHUB_OUTPUT else echo "args=$PYTEST_COVERAGE_ARGS $PYTEST_PARALLELISE_ARGS $PYTEST_ADDITIONAL_ARGS $PYTEST_DURATIONS_ARGS $PYTEST_STORE_ARGS" >> $GITHUB_OUTPUT fi From 786e8264df72b95ea4bd0c0855a8d5cd40270384 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 10:13:47 -0400 Subject: [PATCH 23/82] Fix GHA YML syntax error --- .github/workflows/unit-test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index f7d7d80e01a..4324f96004d 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -134,7 +134,7 @@ jobs: repository: PennyLaneAI/pennylane - name: Determine benchmark name - if: ${{ inputs.pipeline_mode =~ .*"benchmarks".* }} + if: ${{ contains(fromJSON('["benchmarks"]'), inputs.pipeline_mode) }} id: benchmark_name run: | job_name="${{ inputs.job_name }}" @@ -143,7 +143,7 @@ jobs: echo "benchmark_name=$_benchmark_name" >> $GITHUB_OUTPUT - name: Cache reference benchmarks - if: ${{ inputs.pipeline_mode =~ .*"benchmarks".* }} + if: ${{ contains(fromJSON('["benchmarks"]'), inputs.pipeline_mode) }} id: benchmark-cache uses: actions/cache@v3 with: From 212733ff6aefda10f38eb42b102efb9bd2654044 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 10:45:13 -0400 Subject: [PATCH 24/82] Attempt to set strategy for sub-action --- .github/workflows/package_warnings_as_errors.yml | 14 +++++++------- .github/workflows/unit-test.yml | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 659969bdb88..860aa2b42c2 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -12,15 +12,15 @@ concurrency: jobs: test-warnings-as-errors: - uses: ./.github/workflows/interface-unit-tests.yml strategy: fail-fast: false max-parallel: 1 secrets: codecov_token: ${{ secrets.CODECOV_TOKEN }} - with: - branch: ${{ github.ref }} - skip_ci_test_jobs: 'qcut-tests' - python_warning_level: 'error' - pipeline_mode: 'warnings' - \ No newline at end of file + steps: + - uses: ./.github/workflows/interface-unit-tests.yml + with: + branch: ${{ github.ref }} + skip_ci_test_jobs: 'qcut-tests' + python_warning_level: 'error' + pipeline_mode: 'warnings' diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 4324f96004d..dc5d416a5f0 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -154,7 +154,7 @@ jobs: id: continue run: >- echo "confirm=${{ - contains(fromJSON('["unit-tests", "benchmarks"]'), inputs.pipeline_mode) + contains(fromJSON('["unit-tests", "benchmarks", "warnings"]'), inputs.pipeline_mode) || (inputs.pipeline_mode == 'reference-benchmarks' && steps.benchmark-cache.outputs.cache-hit != 'true' )}}" >> $GITHUB_OUTPUT From 5a419140b5ee6e2f9db197da7942054cf29d0c5a Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 10:46:46 -0400 Subject: [PATCH 25/82] Attempt to set strategy for sub-action again --- .github/workflows/package_warnings_as_errors.yml | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 860aa2b42c2..4445d57237e 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -17,10 +17,9 @@ jobs: max-parallel: 1 secrets: codecov_token: ${{ secrets.CODECOV_TOKEN }} - steps: - - uses: ./.github/workflows/interface-unit-tests.yml - with: - branch: ${{ github.ref }} - skip_ci_test_jobs: 'qcut-tests' - python_warning_level: 'error' - pipeline_mode: 'warnings' + uses: ./.github/workflows/interface-unit-tests.yml + with: + branch: ${{ github.ref }} + skip_ci_test_jobs: 'qcut-tests' + python_warning_level: 'error' + pipeline_mode: 'warnings' From 0373a521f88e8e06923824c770f893602ce743d6 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 11:03:13 -0400 Subject: [PATCH 26/82] Move with branch in yaml --- .github/workflows/interface-unit-tests.yml | 2 +- .github/workflows/package_warnings_as_errors.yml | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 0dd8386d96d..c1990529a96 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -49,7 +49,7 @@ on: default: false python_warning_level: description: Sets the default Python warning level as defined by https://docs.python.org/3/using/cmdline.html#envvar-PYTHONWARNINGS - required: false + required: true type: string default: 'default' diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 4445d57237e..3c3c40b75b3 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -18,8 +18,8 @@ jobs: secrets: codecov_token: ${{ secrets.CODECOV_TOKEN }} uses: ./.github/workflows/interface-unit-tests.yml - with: - branch: ${{ github.ref }} - skip_ci_test_jobs: 'qcut-tests' - python_warning_level: 'error' - pipeline_mode: 'warnings' + with: + branch: ${{ github.ref }} + skip_ci_test_jobs: 'qcut-tests' + python_warning_level: 'error' + pipeline_mode: 'warnings' From 523235c47f3957b08db426dd7c27384939f80ddc Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 11:04:15 -0400 Subject: [PATCH 27/82] Make required item optional --- .github/workflows/interface-unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index c1990529a96..0dd8386d96d 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -49,7 +49,7 @@ on: default: false python_warning_level: description: Sets the default Python warning level as defined by https://docs.python.org/3/using/cmdline.html#envvar-PYTHONWARNINGS - required: true + required: false type: string default: 'default' From 07b51b7769f1701631aca6ff6439d154da9455f9 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 11:14:18 -0400 Subject: [PATCH 28/82] Ignore import warnings due to external packages --- tests/pytest.ini | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/pytest.ini b/tests/pytest.ini index 7c99b8c09ca..372894779d5 100644 --- a/tests/pytest.ini +++ b/tests/pytest.ini @@ -22,4 +22,5 @@ markers = addopts = --benchmark-disable xfail_strict=true filterwarnings = - error::pennylane.PennyLaneDeprecationWarning \ No newline at end of file + error::pennylane.PennyLaneDeprecationWarning + ignore:ImportWarning From 749fa012bd133d7e33f141617b8f6bb7e2268948 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 11:56:03 -0400 Subject: [PATCH 29/82] Add conditional splitting support when using WAE --- .github/workflows/interface-unit-tests.yml | 57 +++++++++++++++++++--- tests/pytest.ini | 1 - 2 files changed, 51 insertions(+), 7 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 0dd8386d96d..4efba31b44c 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -71,6 +71,22 @@ jobs: "default": ["3.10"] } EOF + elif [ "${{ inputs.python_warning_level }}" == "error" ]; + then + cat >python_versions.json <<-EOF + { + "default": ["3.12"], + "torch-tests": ["3.12"], + "tf-tests": ["3.12"], + "jax-tests": ["3.12"], + "all-interfaces-tests": ["3.12"], + "external-libraries-tests": ["3.12"], + "qcut-tests": ["3.12"], + "qchem-tests": ["3.12"], + "gradients-tests": ["3.12"], + "data-tests": ["3.12"], + "device-tests": ["3.12"] } + EOF else cat >python_versions.json <<-EOF { @@ -107,6 +123,18 @@ jobs: "device-tests": 2 } EOF + elif [ "${{ inputs.python_warning_level }}" == "error" ]; + then + cat >matrix_max_parallel.json <<-EOF + { + "default": 1, + "core-tests": 1, + "gradients-tests": 1, + "jax-tests": 1, + "tf-tests": 1, + "device-tests": 1 + } + EOF else cat >matrix_max_parallel.json <<-EOF { @@ -123,6 +151,19 @@ jobs: jq . matrix_max_parallel.json echo "matrix_max_parallel=$(jq -r tostring matrix_max_parallel.json)" >> $GITHUB_OUTPUT + - name: Enable splitting of tests + id: job_split + run: | + if [ "${{ inputs.python_warning_level }}" == "error" ]; + then + ENABLE_SPLIT=0 + else + ENABLE_SPLIT=1 + fi + + jq . matrix_max_parallel.json + echo "enable_split=$ENABLE_SPLIT" >> $GITHUB_OUTPUT + - name: Setup Job to Skip id: jobs_to_skip env: @@ -141,6 +182,7 @@ jobs: matrix-max-parallel: ${{ steps.max_parallel.outputs.matrix_max_parallel }} python-version: ${{ steps.python_versions.outputs.python_versions }} jobs-to-skip: ${{ steps.jobs_to_skip.outputs.jobs_to_skip }} + enable_split: ${{ steps.jobs_to_skip.outputs.enable_split }} torch-tests: needs: @@ -219,7 +261,8 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: [1, 2, 3] + group: >- + ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && [1, 2, 3] || [1] }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests @@ -239,7 +282,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: --splits 3 --group ${{ matrix.group }} + pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == "1" && format('--splits {0} --group {1}', '3', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -258,7 +301,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: [1, 2, 3, 4, 5] + group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && [1, 2, 3, 4, 5] || [1] }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).jax-tests @@ -278,7 +321,9 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: --splits 5 --group ${{ matrix.group }} + pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + + pytest_durations_file_path: '.github/workflows/jax_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -297,7 +342,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: [1, 2, 3, 4, 5] + group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && [1, 2, 3, 4, 5] || [1] }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).core-tests @@ -317,7 +362,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: --splits 5 --group ${{ matrix.group }} + pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} pytest_durations_file_path: '.github/workflows/core_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split diff --git a/tests/pytest.ini b/tests/pytest.ini index 372894779d5..19811af01bf 100644 --- a/tests/pytest.ini +++ b/tests/pytest.ini @@ -23,4 +23,3 @@ addopts = --benchmark-disable xfail_strict=true filterwarnings = error::pennylane.PennyLaneDeprecationWarning - ignore:ImportWarning From 80b483d538b0dbcdc5be19db08ec59a878aa8cbf Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 11:58:49 -0400 Subject: [PATCH 30/82] Add fromJson --- .github/workflows/interface-unit-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 4efba31b44c..4572f6feace 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -262,7 +262,7 @@ jobs: }} matrix: group: >- - ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && [1, 2, 3] || [1] }} + ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && fromJson("[1, 2, 3]") || fromJson("[1]") }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests @@ -301,7 +301,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && [1, 2, 3, 4, 5] || [1] }} + group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && fromJson("[1, 2, 3, 4, 5]") || fromJsom("[1]") }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).jax-tests @@ -342,7 +342,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && [1, 2, 3, 4, 5] || [1] }} + group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && fromJson("[1, 2, 3, 4, 5]") || fromJson("[1]") }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).core-tests From a5de61479c33c38501d4f9031bf733af585aaf11 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 12:04:34 -0400 Subject: [PATCH 31/82] Try coerce GHA to accept the matrix values --- .github/workflows/interface-unit-tests.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 4572f6feace..9650535ae2c 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -262,7 +262,7 @@ jobs: }} matrix: group: >- - ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && fromJson("[1, 2, 3]") || fromJson("[1]") }} + ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) == 1 && "[1, 2, 3]" || "[1]" }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests @@ -282,7 +282,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == "1" && format('--splits {0} --group {1}', '3', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) == "1" && format('--splits {0} --group {1}', '3', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -301,7 +301,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && fromJson("[1, 2, 3, 4, 5]") || fromJsom("[1]") }} + group: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) && "[1, 2, 3, 4, 5]" || "[1]" }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).jax-tests @@ -321,7 +321,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} pytest_durations_file_path: '.github/workflows/jax_tests_durations.json' @@ -342,7 +342,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && fromJson("[1, 2, 3, 4, 5]") || fromJson("[1]") }} + group: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) && "[1, 2, 3, 4, 5]" || "[1]" }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).core-tests @@ -362,7 +362,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} pytest_durations_file_path: '.github/workflows/core_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From 2c0c8dc1814eeb731ec76f5382bbeacb884687c0 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 12:07:38 -0400 Subject: [PATCH 32/82] Try coerce GHA to accept the matrix values again --- .github/workflows/interface-unit-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 9650535ae2c..e2c3162250f 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -262,7 +262,7 @@ jobs: }} matrix: group: >- - ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) == 1 && "[1, 2, 3]" || "[1]" }} + ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) == 1 && [1, 2, 3] || [1] }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests @@ -301,7 +301,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) && "[1, 2, 3, 4, 5]" || "[1]" }} + group: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) && [1, 2, 3, 4, 5] || [1] }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).jax-tests @@ -342,7 +342,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) && "[1, 2, 3, 4, 5]" || "[1]" }} + group: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) && [1, 2, 3, 4, 5] || [1] }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).core-tests From 5f197aac10c4d545f12adbf4383ebe0e27189d5e Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 12:25:36 -0400 Subject: [PATCH 33/82] Try coerce GHA to accept the matrix values again+1 --- .github/workflows/interface-unit-tests.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index e2c3162250f..c2ae020557c 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -262,7 +262,7 @@ jobs: }} matrix: group: >- - ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) == 1 && [1, 2, 3] || [1] }} + ${{ needs.setup-ci-load.outputs.enable_split == 1 && [1, 2, 3] || [1] }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests @@ -282,7 +282,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) == "1" && format('--splits {0} --group {1}', '3', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == "1" && format('--splits {0} --group {1}', '3', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -301,7 +301,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) && [1, 2, 3, 4, 5] || [1] }} + group: ${{ needs.setup-ci-load.outputs.enable_split && [1, 2, 3, 4, 5] || [1] }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).jax-tests @@ -321,7 +321,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} pytest_durations_file_path: '.github/workflows/jax_tests_durations.json' @@ -342,7 +342,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) && [1, 2, 3, 4, 5] || [1] }} + group: ${{ needs.setup-ci-load.outputs.enable_split && [1, 2, 3, 4, 5] || [1] }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).core-tests @@ -362,7 +362,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable_split) == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} pytest_durations_file_path: '.github/workflows/core_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From 124431cd7ec31f45fafff06f1b12bc061dbb0f6f Mon Sep 17 00:00:00 2001 From: Lee James O'Riordan Date: Fri, 13 Sep 2024 13:00:58 -0400 Subject: [PATCH 34/82] Update .github/workflows/interface-unit-tests.yml Co-authored-by: Rashid N H M <95639609+rashidnhm@users.noreply.github.com> --- .github/workflows/interface-unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index c2ae020557c..ca2bcfd48eb 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -301,7 +301,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ needs.setup-ci-load.outputs.enable_split && [1, 2, 3, 4, 5] || [1] }} + group: ${{ needs.setup-ci-load.outputs.enable_split == '1' && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).jax-tests From 6c2ae745859738f2afc6aa555b983c4687295ec8 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 13:06:02 -0400 Subject: [PATCH 35/82] Treat the conditional section as objects with fromJson --- .github/workflows/interface-unit-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index ca2bcfd48eb..3a864ad6eda 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -262,7 +262,7 @@ jobs: }} matrix: group: >- - ${{ needs.setup-ci-load.outputs.enable_split == 1 && [1, 2, 3] || [1] }} + ${{ needs.setup-ci-load.outputs.enable_split == '1' && fromJSON('[1, 2, 3]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests @@ -342,7 +342,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ needs.setup-ci-load.outputs.enable_split && [1, 2, 3, 4, 5] || [1] }} + group: ${{ needs.setup-ci-load.outputs.enable_split && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).core-tests From 4adffd839ed256fe73622912e2181006b56272e9 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 13:09:43 -0400 Subject: [PATCH 36/82] More coercing --- .github/workflows/interface-unit-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 3a864ad6eda..92f487f2c10 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -282,7 +282,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == "1" && format('--splits {0} --group {1}', '3', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -321,7 +321,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} pytest_durations_file_path: '.github/workflows/jax_tests_durations.json' @@ -362,7 +362,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == "1" && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || format('--splits {0} --group {1}', '1', matrix.group) }} pytest_durations_file_path: '.github/workflows/core_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From 144b3212dd67287ebde136b4ef36d6053d94332b Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 13:26:24 -0400 Subject: [PATCH 37/82] Remove splits when not required --- .github/workflows/interface-unit-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 92f487f2c10..e46a57758f8 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -282,7 +282,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -321,7 +321,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} pytest_durations_file_path: '.github/workflows/jax_tests_durations.json' @@ -362,7 +362,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || format('--splits {0} --group {1}', '1', matrix.group) }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} pytest_durations_file_path: '.github/workflows/core_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From 6eac2a250b6c4c6db5f3471fa81d12a84eb1ccb6 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 13:34:04 -0400 Subject: [PATCH 38/82] Downgrade py versions --- .github/workflows/interface-unit-tests.yml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index e46a57758f8..a7e3c6bff15 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -75,17 +75,17 @@ jobs: then cat >python_versions.json <<-EOF { - "default": ["3.12"], - "torch-tests": ["3.12"], - "tf-tests": ["3.12"], - "jax-tests": ["3.12"], - "all-interfaces-tests": ["3.12"], - "external-libraries-tests": ["3.12"], - "qcut-tests": ["3.12"], - "qchem-tests": ["3.12"], - "gradients-tests": ["3.12"], - "data-tests": ["3.12"], - "device-tests": ["3.12"] } + "default": ["3.10"], + "torch-tests": ["3.10"], + "tf-tests": ["3.10"], + "jax-tests": ["3.10"], + "all-interfaces-tests": ["3.10"], + "external-libraries-tests": ["3.10"], + "qcut-tests": ["3.10"], + "qchem-tests": ["3.10"], + "gradients-tests": ["3.10"], + "data-tests": ["3.10"], + "device-tests": ["3.10"] } EOF else cat >python_versions.json <<-EOF From 7ada97b5319c1e1221b36788b8fc63b52005a067 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 13:35:25 -0400 Subject: [PATCH 39/82] Add pandas to avoid import errors in WAE --- requirements-ci.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/requirements-ci.txt b/requirements-ci.txt index 083beaae25f..38b70736dbf 100644 --- a/requirements-ci.txt +++ b/requirements-ci.txt @@ -13,3 +13,4 @@ matplotlib requests rich tomli # Drop once minimum Python version is 3.11 +pandas From 67e79ec9b490008bb44cc1b173a9dcbd88ab5180 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 13:46:28 -0400 Subject: [PATCH 40/82] Remove durations and ensure no lightened settings --- .github/workflows/interface-unit-tests.yml | 14 ++++++-------- .github/workflows/package_warnings_as_errors.yml | 1 + 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index a7e3c6bff15..732533f57e5 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -283,9 +283,9 @@ jobs: pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} - pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' + pytest_durations_file_path: ${{ needs.setup-ci-load.outputs.enable_split == '1' && '.github/workflows/tf_tests_durations.json' || '' }} pytest_store_durations: ${{ inputs.pytest_store_durations }} - additional_pip_packages: pytest-split + additional_pip_packages: ${{ needs.setup-ci-load.outputs.enable_split == '1' && 'pytest-split' || '' }} requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'tf.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} python_warning_level: ${{ inputs.python_warning_level }} @@ -322,11 +322,9 @@ jobs: pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} - - - pytest_durations_file_path: '.github/workflows/jax_tests_durations.json' + pytest_durations_file_path: ${{ needs.setup-ci-load.outputs.enable_split == '1' && '.github/workflows/jax_tests_durations.json' || '' }} pytest_store_durations: ${{ inputs.pytest_store_durations }} - additional_pip_packages: pytest-split + additional_pip_packages: ${{ needs.setup-ci-load.outputs.enable_split == '1' && 'pytest-split' || '' }} requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'jax.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} python_warning_level: ${{ inputs.python_warning_level }} @@ -363,9 +361,9 @@ jobs: pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} - pytest_durations_file_path: '.github/workflows/core_tests_durations.json' + pytest_durations_file_path: ${{ needs.setup-ci-load.outputs.enable_split == '1' && '.github/workflows/core_tests_durations.json' || '' }} pytest_store_durations: ${{ inputs.pytest_store_durations }} - additional_pip_packages: pytest-split + additional_pip_packages: ${{ needs.setup-ci-load.outputs.enable_split == '1' && 'pytest-split' || '' }} requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'core.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} python_warning_level: ${{ inputs.python_warning_level }} diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 3c3c40b75b3..9bb4ed573f0 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -23,3 +23,4 @@ jobs: skip_ci_test_jobs: 'qcut-tests' python_warning_level: 'error' pipeline_mode: 'warnings' + run_lightened_ci: false From 9e1ced3eb4be7a1959afa772e021d5d881e44aec Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 13:52:53 -0400 Subject: [PATCH 41/82] Ensure continue on collection errors --- .github/workflows/unit-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index dc5d416a5f0..4631e03d441 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -186,7 +186,7 @@ jobs: if [[ "$PIPELINE_MODE" =~ .*"benchmarks".* ]]; then echo "args=$PYTEST_BENCHMARKS_ARGS $PYTEST_ADDITIONAL_ARGS" >> $GITHUB_OUTPUT elif [[ "$PIPELINE_MODE" =~ .*"warnings".* ]]; then - echo "args=$PYTEST_ADDITIONAL_ARGS" >> $GITHUB_OUTPUT + echo "args=$PYTEST_ADDITIONAL_ARGS --continue-on-collection-errors" >> $GITHUB_OUTPUT else echo "args=$PYTEST_COVERAGE_ARGS $PYTEST_PARALLELISE_ARGS $PYTEST_ADDITIONAL_ARGS $PYTEST_DURATIONS_ARGS $PYTEST_STORE_ARGS" >> $GITHUB_OUTPUT fi From e7463f0ebba3082c3bcbc02c804ca90b95eff98a Mon Sep 17 00:00:00 2001 From: Lee James O'Riordan Date: Fri, 13 Sep 2024 14:05:21 -0400 Subject: [PATCH 42/82] Update .github/workflows/interface-unit-tests.yml Co-authored-by: Rashid N H M <95639609+rashidnhm@users.noreply.github.com> --- .github/workflows/interface-unit-tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 732533f57e5..8c75801aaa3 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -161,7 +161,6 @@ jobs: ENABLE_SPLIT=1 fi - jq . matrix_max_parallel.json echo "enable_split=$ENABLE_SPLIT" >> $GITHUB_OUTPUT - name: Setup Job to Skip From 95822bc1653fdc3953b3e4c234e605f50fafe865 Mon Sep 17 00:00:00 2001 From: Lee James O'Riordan Date: Fri, 13 Sep 2024 14:27:55 -0400 Subject: [PATCH 43/82] Update .github/workflows/interface-unit-tests.yml Co-authored-by: Mudit Pandey --- .github/workflows/interface-unit-tests.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 8c75801aaa3..839860e8a8b 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -127,12 +127,7 @@ jobs: then cat >matrix_max_parallel.json <<-EOF { - "default": 1, - "core-tests": 1, - "gradients-tests": 1, - "jax-tests": 1, - "tf-tests": 1, - "device-tests": 1 + "default": 1 } EOF else From a74672125b9d9ee446a4b2e5ddaeea72c23c1f68 Mon Sep 17 00:00:00 2001 From: Lee James O'Riordan Date: Fri, 13 Sep 2024 14:28:01 -0400 Subject: [PATCH 44/82] Update .github/workflows/interface-unit-tests.yml Co-authored-by: Mudit Pandey --- .github/workflows/interface-unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 839860e8a8b..2b34b404fc5 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -277,7 +277,7 @@ jobs: pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} - pytest_durations_file_path: ${{ needs.setup-ci-load.outputs.enable_split == '1' && '.github/workflows/tf_tests_durations.json' || '' }} + pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: ${{ needs.setup-ci-load.outputs.enable_split == '1' && 'pytest-split' || '' }} requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'tf.txt' || '' }} From 2d418d2d12a5487ad7f670091104e1abfd2810ce Mon Sep 17 00:00:00 2001 From: Lee James O'Riordan Date: Fri, 13 Sep 2024 14:28:33 -0400 Subject: [PATCH 45/82] Update .github/workflows/package_warnings_as_errors.yml --- .github/workflows/package_warnings_as_errors.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 9bb4ed573f0..813ccd2c34a 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -4,7 +4,6 @@ on: schedule: - cron: '35 2 * * 0' workflow_dispatch: - pull_request: concurrency: group: warnings-as-errors-tests-${{ github.ref }} From ade9049c9296be84824fe28ac2de4933e3f1354e Mon Sep 17 00:00:00 2001 From: Lee James O'Riordan Date: Fri, 13 Sep 2024 14:28:42 -0400 Subject: [PATCH 46/82] Update .github/workflows/package_warnings_as_errors.yml Co-authored-by: Mudit Pandey --- .github/workflows/package_warnings_as_errors.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 813ccd2c34a..dd529e626dc 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -19,7 +19,6 @@ jobs: uses: ./.github/workflows/interface-unit-tests.yml with: branch: ${{ github.ref }} - skip_ci_test_jobs: 'qcut-tests' python_warning_level: 'error' pipeline_mode: 'warnings' run_lightened_ci: false From 9589c9f43ed6346a92e7a0dd7ea326d5634bc653 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 14:37:58 -0400 Subject: [PATCH 47/82] Fix durations --- .github/workflows/interface-unit-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 2b34b404fc5..412be65b99b 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -277,7 +277,7 @@ jobs: pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} - pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' + pytest_durations_file_path: .github/workflows/tf_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: ${{ needs.setup-ci-load.outputs.enable_split == '1' && 'pytest-split' || '' }} requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'tf.txt' || '' }} @@ -316,7 +316,7 @@ jobs: pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} - pytest_durations_file_path: ${{ needs.setup-ci-load.outputs.enable_split == '1' && '.github/workflows/jax_tests_durations.json' || '' }} + pytest_durations_file_path: .github/workflows/jax_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: ${{ needs.setup-ci-load.outputs.enable_split == '1' && 'pytest-split' || '' }} requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'jax.txt' || '' }} @@ -355,7 +355,7 @@ jobs: pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} - pytest_durations_file_path: ${{ needs.setup-ci-load.outputs.enable_split == '1' && '.github/workflows/core_tests_durations.json' || '' }} + pytest_durations_file_path: .github/workflows/core_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: ${{ needs.setup-ci-load.outputs.enable_split == '1' && 'pytest-split' || '' }} requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'core.txt' || '' }} From 6f6811426d5fac30fb59849ab50c9f641f14284b Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 14:46:36 -0400 Subject: [PATCH 48/82] Always include split package --- .github/workflows/interface-unit-tests.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 412be65b99b..19619aefbe9 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -277,9 +277,9 @@ jobs: pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} - pytest_durations_file_path: .github/workflows/tf_tests_durations.json + pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} - additional_pip_packages: ${{ needs.setup-ci-load.outputs.enable_split == '1' && 'pytest-split' || '' }} + additional_pip_packages: pytest-split requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'tf.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} python_warning_level: ${{ inputs.python_warning_level }} @@ -318,7 +318,7 @@ jobs: pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} pytest_durations_file_path: .github/workflows/jax_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} - additional_pip_packages: ${{ needs.setup-ci-load.outputs.enable_split == '1' && 'pytest-split' || '' }} + additional_pip_packages: pytest-split requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'jax.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} python_warning_level: ${{ inputs.python_warning_level }} @@ -357,7 +357,7 @@ jobs: pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} pytest_durations_file_path: .github/workflows/core_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} - additional_pip_packages: ${{ needs.setup-ci-load.outputs.enable_split == '1' && 'pytest-split' || '' }} + additional_pip_packages: pytest-split requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'core.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} python_warning_level: ${{ inputs.python_warning_level }} From 12d74b89684dd13c5e183c532ff0770151813ee6 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 16:07:10 -0400 Subject: [PATCH 49/82] reformat string structure --- .github/workflows/interface-unit-tests.yml | 18 +++++++++--------- .github/workflows/unit-test.yml | 1 + 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 19619aefbe9..b44df753ae3 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -151,9 +151,9 @@ jobs: run: | if [ "${{ inputs.python_warning_level }}" == "error" ]; then - ENABLE_SPLIT=0 + ENABLE_SPLIT='0' else - ENABLE_SPLIT=1 + ENABLE_SPLIT='1' fi echo "enable_split=$ENABLE_SPLIT" >> $GITHUB_OUTPUT @@ -176,7 +176,7 @@ jobs: matrix-max-parallel: ${{ steps.max_parallel.outputs.matrix_max_parallel }} python-version: ${{ steps.python_versions.outputs.python_versions }} jobs-to-skip: ${{ steps.jobs_to_skip.outputs.jobs_to_skip }} - enable_split: ${{ steps.jobs_to_skip.outputs.enable_split }} + enable-split: ${{ steps.jobs_to_skip.outputs.enable_split }} torch-tests: needs: @@ -256,7 +256,7 @@ jobs: }} matrix: group: >- - ${{ needs.setup-ci-load.outputs.enable_split == '1' && fromJSON('[1, 2, 3]') || fromJSON('[1]') }} + ${{ needs.setup-ci-load.outputs.enable-split == '1' && fromJSON('[1, 2, 3]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests @@ -276,7 +276,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -295,7 +295,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ needs.setup-ci-load.outputs.enable_split == '1' && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} + group: ${{ needs.setup-ci-load.outputs.enable-split == '1' && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).jax-tests @@ -315,7 +315,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} pytest_durations_file_path: .github/workflows/jax_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -334,7 +334,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ needs.setup-ci-load.outputs.enable_split && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} + group: ${{ needs.setup-ci-load.outputs.enable-split && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).core-tests @@ -354,7 +354,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable_split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} pytest_durations_file_path: .github/workflows/core_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 4631e03d441..d671dbe5382 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -183,6 +183,7 @@ jobs: PYTEST_DURATIONS_ARGS: ${{ inputs.pytest_durations_file_path != '' && format('--durations-path="{0}"', inputs.pytest_durations_file_path) || '' }} PYTEST_STORE_ARGS: ${{ inputs.pytest_store_durations == true && '--store-durations --clean-durations' || '' }} run: | + echo "PYTEST_ADDITIONAL_ARGS=${PYTEST_ADDITIONAL_ARGS}" if [[ "$PIPELINE_MODE" =~ .*"benchmarks".* ]]; then echo "args=$PYTEST_BENCHMARKS_ARGS $PYTEST_ADDITIONAL_ARGS" >> $GITHUB_OUTPUT elif [[ "$PIPELINE_MODE" =~ .*"warnings".* ]]; then From b37ab7513abf77ade6f052b9b2f19d3a8afe9ccd Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 16:16:09 -0400 Subject: [PATCH 50/82] Need more output --- .github/workflows/interface-unit-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index b44df753ae3..ff448015f5c 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -276,7 +276,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || 'dumb' }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -315,7 +315,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || 'cake' }} pytest_durations_file_path: .github/workflows/jax_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -354,7 +354,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || 'test' }} pytest_durations_file_path: .github/workflows/core_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From 392ec4e6c79a1b81941454135580cc308efa1cf9 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 16:25:02 -0400 Subject: [PATCH 51/82] More formatting checks --- .github/workflows/interface-unit-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index ff448015f5c..c25307af446 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -276,7 +276,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || 'dumb' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '3', toJSON(matrix.group) ) || 'dumb' }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -315,7 +315,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || 'cake' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', toJSON(matrix.group) ) || 'cake' }} pytest_durations_file_path: .github/workflows/jax_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -354,7 +354,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || 'test' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', toJSON(matrix.group) ) || 'test' }} pytest_durations_file_path: .github/workflows/core_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From 79a80ec222ada592d54149a053cb0d0aa6da55cb Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 16:34:26 -0400 Subject: [PATCH 52/82] Once more --- .github/workflows/interface-unit-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index c25307af446..d10467b125d 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -276,7 +276,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '3', toJSON(matrix.group) ) || 'dumb' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '3', matrix.group ) || format('--splits {0} --group {1}', '3', matrix.group ) }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -315,7 +315,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', toJSON(matrix.group) ) || 'cake' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || format('--splits {0} --group {1}', '5', matrix.group ) }} pytest_durations_file_path: .github/workflows/jax_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -354,7 +354,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', toJSON(matrix.group) ) || 'test' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', toJSON(matrix.group) ) || format('--splits {0} --group {1}', '5', toJSON(matrix.group) ) }} pytest_durations_file_path: .github/workflows/core_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From 896bca19ab6a3b2eeff1d4661250525ef60d5396 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 16:38:02 -0400 Subject: [PATCH 53/82] Add paren --- .github/workflows/interface-unit-tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index d10467b125d..c21c97af1cd 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -295,7 +295,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ needs.setup-ci-load.outputs.enable-split == '1' && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} + group: ${{ ( needs.setup-ci-load.outputs.enable-split == '1' && fromJSON('[1, 2, 3, 4, 5]') ) || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).jax-tests @@ -315,7 +315,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || format('--splits {0} --group {1}', '5', matrix.group ) }} + pytest_additional_args: ${{ ( needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) ) || format('--splits {0} --group {1}', '5', matrix.group ) }} pytest_durations_file_path: .github/workflows/jax_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From a5bbfe909a96e3f9bd314c63bfaef4c1d172f02e Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 16:40:04 -0400 Subject: [PATCH 54/82] JAXIT --- .github/workflows/interface-unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index c21c97af1cd..39c5bf72668 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -315,7 +315,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ ( needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) ) || format('--splits {0} --group {1}', '5', matrix.group ) }} + pytest_additional_args: ${{ ( needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) ) || needs.setup-ci-load.outputs.enable-split }} pytest_durations_file_path: .github/workflows/jax_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From e9a7c8bbcf2c7d3603c2d0a1539cff9b2809cd85 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 16:45:10 -0400 Subject: [PATCH 55/82] More echo --- .github/workflows/interface-unit-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 39c5bf72668..2ceaf82c849 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -151,11 +151,11 @@ jobs: run: | if [ "${{ inputs.python_warning_level }}" == "error" ]; then - ENABLE_SPLIT='0' + export ENABLE_SPLIT='0' else - ENABLE_SPLIT='1' + export ENABLE_SPLIT='1' fi - + echo "enable_split=$ENABLE_SPLIT echo "enable_split=$ENABLE_SPLIT" >> $GITHUB_OUTPUT - name: Setup Job to Skip From ecc438309b433385d619ecbe202921ec652c553f Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 16:46:08 -0400 Subject: [PATCH 56/82] More echo --- .github/workflows/interface-unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 2ceaf82c849..633963ce770 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -155,7 +155,7 @@ jobs: else export ENABLE_SPLIT='1' fi - echo "enable_split=$ENABLE_SPLIT + echo "enable_split=$ENABLE_SPLIT" echo "enable_split=$ENABLE_SPLIT" >> $GITHUB_OUTPUT - name: Setup Job to Skip From 3bf44288093fe1ff96b1a31ee856ddcf7467e879 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 16:52:24 -0400 Subject: [PATCH 57/82] TF group check --- .github/workflows/interface-unit-tests.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 633963ce770..123aa53bd01 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -155,7 +155,7 @@ jobs: else export ENABLE_SPLIT='1' fi - echo "enable_split=$ENABLE_SPLIT" + echo "enable_split=$ENABLE_SPLIT" >> $GITHUB_OUTPUT - name: Setup Job to Skip @@ -256,7 +256,7 @@ jobs: }} matrix: group: >- - ${{ needs.setup-ci-load.outputs.enable-split == '1' && fromJSON('[1, 2, 3]') || fromJSON('[1]') }} + ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == '1' && fromJSON('[1, 2, 3]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests @@ -276,7 +276,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '3', matrix.group ) || format('--splits {0} --group {1}', '3', matrix.group ) }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -295,7 +295,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ ( needs.setup-ci-load.outputs.enable-split == '1' && fromJSON('[1, 2, 3, 4, 5]') ) || fromJSON('[1]') }} + group: ${{ needs.setup-ci-load.outputs.enable-split == '1' && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).jax-tests @@ -315,7 +315,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ ( needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) ) || needs.setup-ci-load.outputs.enable-split }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} pytest_durations_file_path: .github/workflows/jax_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -354,7 +354,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', toJSON(matrix.group) ) || format('--splits {0} --group {1}', '5', toJSON(matrix.group) ) }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} pytest_durations_file_path: .github/workflows/core_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From a44a8dbbdb8e6a8d8c4e99e15d9ad0361007ee80 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 16:56:33 -0400 Subject: [PATCH 58/82] Multiple groupings --- .github/workflows/interface-unit-tests.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 123aa53bd01..0eb8118adf9 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -276,7 +276,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} + pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -295,7 +295,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ needs.setup-ci-load.outputs.enable-split == '1' && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} + group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == '1' && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).jax-tests @@ -315,7 +315,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} + pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} pytest_durations_file_path: .github/workflows/jax_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -334,7 +334,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ needs.setup-ci-load.outputs.enable-split && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} + group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).core-tests @@ -354,7 +354,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} + pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} pytest_durations_file_path: .github/workflows/core_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From 3258d2c93aa48f4adab9866d22c9e612677bf95b Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 17:02:48 -0400 Subject: [PATCH 59/82] More darting with TF tests --- .github/workflows/interface-unit-tests.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 0eb8118adf9..333fd6d93d4 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -256,7 +256,7 @@ jobs: }} matrix: group: >- - ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == '1' && fromJSON('[1, 2, 3]') || fromJSON('[1]') }} + ${{ fromJSON(needs.setup-ci-load.outputs.enable-split).tf-tests == '1' && fromJSON('[1, 2, 3]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests @@ -276,7 +276,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} + pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split).tf-tests == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -295,7 +295,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == '1' && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} + group: ${{ needs.setup-ci-load.outputs.enable-split == '1' && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).jax-tests @@ -315,7 +315,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group) || '' }} pytest_durations_file_path: .github/workflows/jax_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -334,7 +334,7 @@ jobs: || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default }} matrix: - group: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} + group: ${{ needs.setup-ci-load.outputs.enable-split && fromJSON('[1, 2, 3, 4, 5]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).core-tests @@ -354,7 +354,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split) == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '5', matrix.group ) || '' }} pytest_durations_file_path: .github/workflows/core_tests_durations.json pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split From 33495feadddb54f4b77304b6b089b89c69feca7e Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 17:18:54 -0400 Subject: [PATCH 60/82] Enable debug logging --- .github/workflows/interface-unit-tests.yml | 16 ++++++++++++++-- .github/workflows/unit-test.yml | 1 - 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 333fd6d93d4..1bf7685cfbd 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -56,6 +56,9 @@ on: jobs: setup-ci-load: runs-on: ubuntu-latest + env: + ACTIONS_RUNNER_DEBUG: true + ACTIONS_STEP_DEBUG: true steps: - name: Setup Python Versions @@ -179,6 +182,9 @@ jobs: enable-split: ${{ steps.jobs_to_skip.outputs.enable_split }} torch-tests: + env: + ACTIONS_RUNNER_DEBUG: true + ACTIONS_STEP_DEBUG: true needs: - setup-ci-load strategy: @@ -246,6 +252,9 @@ jobs: tf-tests: + env: + ACTIONS_RUNNER_DEBUG: true + ACTIONS_STEP_DEBUG: true needs: - setup-ci-load strategy: @@ -256,7 +265,7 @@ jobs: }} matrix: group: >- - ${{ fromJSON(needs.setup-ci-load.outputs.enable-split).tf-tests == '1' && fromJSON('[1, 2, 3]') || fromJSON('[1]') }} + ${{ needs.setup-ci-load.outputs.enable-split == '1' && fromJSON('[1, 2, 3]') || fromJSON('[1]') }} python-version: >- ${{ fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests @@ -276,7 +285,7 @@ jobs: install_pennylane_lightning_master: true pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: ${{ fromJSON(needs.setup-ci-load.outputs.enable-split).tf-tests == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} + pytest_additional_args: ${{ needs.setup-ci-load.outputs.enable-split == '1' && format('--splits {0} --group {1}', '3', matrix.group) || '' }} pytest_durations_file_path: '.github/workflows/tf_tests_durations.json' pytest_store_durations: ${{ inputs.pytest_store_durations }} additional_pip_packages: pytest-split @@ -286,6 +295,9 @@ jobs: jax-tests: + env: + ACTIONS_RUNNER_DEBUG: true + ACTIONS_STEP_DEBUG: true needs: - setup-ci-load strategy: diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index d671dbe5382..4631e03d441 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -183,7 +183,6 @@ jobs: PYTEST_DURATIONS_ARGS: ${{ inputs.pytest_durations_file_path != '' && format('--durations-path="{0}"', inputs.pytest_durations_file_path) || '' }} PYTEST_STORE_ARGS: ${{ inputs.pytest_store_durations == true && '--store-durations --clean-durations' || '' }} run: | - echo "PYTEST_ADDITIONAL_ARGS=${PYTEST_ADDITIONAL_ARGS}" if [[ "$PIPELINE_MODE" =~ .*"benchmarks".* ]]; then echo "args=$PYTEST_BENCHMARKS_ARGS $PYTEST_ADDITIONAL_ARGS" >> $GITHUB_OUTPUT elif [[ "$PIPELINE_MODE" =~ .*"warnings".* ]]; then From 33cbeb2e122b0a77867859e1975129e08f742d5e Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 13 Sep 2024 17:21:36 -0400 Subject: [PATCH 61/82] Enable debug logging+1 --- .github/workflows/interface-unit-tests.yml | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 1bf7685cfbd..e08464c2c22 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -52,13 +52,13 @@ on: required: false type: string default: 'default' +env: + ACTIONS_RUNNER_DEBUG: true + ACTIONS_STEP_DEBUG: true jobs: setup-ci-load: runs-on: ubuntu-latest - env: - ACTIONS_RUNNER_DEBUG: true - ACTIONS_STEP_DEBUG: true steps: - name: Setup Python Versions @@ -182,9 +182,6 @@ jobs: enable-split: ${{ steps.jobs_to_skip.outputs.enable_split }} torch-tests: - env: - ACTIONS_RUNNER_DEBUG: true - ACTIONS_STEP_DEBUG: true needs: - setup-ci-load strategy: @@ -252,9 +249,6 @@ jobs: tf-tests: - env: - ACTIONS_RUNNER_DEBUG: true - ACTIONS_STEP_DEBUG: true needs: - setup-ci-load strategy: @@ -295,9 +289,6 @@ jobs: jax-tests: - env: - ACTIONS_RUNNER_DEBUG: true - ACTIONS_STEP_DEBUG: true needs: - setup-ci-load strategy: From fe928a74212cee582cfc92bc4982891b0ea41204 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 24 Oct 2024 09:56:14 -0400 Subject: [PATCH 62/82] Fix merge errors --- .github/workflows/interface-unit-tests.yml | 4 ++-- pennylane/devices/tests/pytest.ini | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index ec9047a138c..376c96cdf25 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -719,9 +719,9 @@ jobs: if: >- ${{ always() && + inputs.upload_to_codecov == true && !contains(needs.*.result, 'failure') && - !contains(needs.*.result, 'cancelled') && - inputs.pipeline_mode == 'unit-tests' + !contains(needs.*.result, 'cancelled') }} steps: diff --git a/pennylane/devices/tests/pytest.ini b/pennylane/devices/tests/pytest.ini index 7444d17af76..21b3865680d 100644 --- a/pennylane/devices/tests/pytest.ini +++ b/pennylane/devices/tests/pytest.ini @@ -1,4 +1,3 @@ [pytest] markers = skip_unsupported: skip a test if it uses an operation unsupported on a device -addopts = --benchmark-disable From aff8399ae07c840a2c5b63826a03dd6910a0a99e Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 24 Oct 2024 11:06:12 -0400 Subject: [PATCH 63/82] Temp trigger WAE --- .../workflows/package_warnings_as_errors.yml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index dd529e626dc..ddf43c256b2 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -4,6 +4,15 @@ on: schedule: - cron: '35 2 * * 0' workflow_dispatch: + push: + branches: + - master + pull_request: + types: + - opened + - reopened + - synchronize + - ready_for_review concurrency: group: warnings-as-errors-tests-${{ github.ref }} @@ -20,5 +29,12 @@ jobs: with: branch: ${{ github.ref }} python_warning_level: 'error' - pipeline_mode: 'warnings' run_lightened_ci: false + skip_ci_test_jobs: | + tf-tests + all-interfaces-tests + external-libraries-tests + qcut-tests + qchem-tests + gradients-tests + device-tests From 52014834df32af408df94d6f38c076e7526afd78 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 24 Oct 2024 11:24:46 -0400 Subject: [PATCH 64/82] Move warning config into pytest_additional_args --- .github/workflows/interface-unit-tests.yml | 28 ++++++++++------------ 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 376c96cdf25..bf99c44b47c 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -269,9 +269,9 @@ jobs: additional_pip_packages_post: ${{ needs.default-dependency-versions.outputs.pennylane-lightning-latest }} pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: torch and not qcut and not finite-diff and not param-shift + pytest_additional_args: -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'torch.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} - python_warning_level: ${{ inputs.python_warning_level }} autograd-tests: @@ -303,8 +303,8 @@ jobs: additional_pip_packages_post: ${{ needs.default-dependency-versions.outputs.pennylane-lightning-latest }} pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: autograd and not qcut and not finite-diff and not param-shift + pytest_additional_args: -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} - python_warning_level: ${{ inputs.python_warning_level }} tf-tests: @@ -339,12 +339,10 @@ jobs: additional_pip_packages_post: ${{ needs.default-dependency-versions.outputs.pennylane-lightning-latest }} pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: tf and not qcut and not finite-diff and not param-shift - pytest_additional_args: --splits 3 --group ${{ matrix.group }} + pytest_additional_args: --splits 3 --group ${{ matrix.group }} -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} pytest_durations_file_path: '.github/durations/tf_tests_durations.json' requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'tf.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} - python_warning_level: ${{ inputs.python_warning_level }} - jax-tests: needs: @@ -378,11 +376,10 @@ jobs: additional_pip_packages_post: ${{ needs.default-dependency-versions.outputs.pennylane-lightning-latest }} pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: jax and not qcut and not finite-diff and not param-shift - pytest_additional_args: --dist=loadscope --splits 4 --group ${{ matrix.group }} + pytest_additional_args: --dist=loadscope --splits 4 --group ${{ matrix.group }} -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} pytest_durations_file_path: '.github/durations/jax_tests_durations.json' requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'jax.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} - python_warning_level: ${{ inputs.python_warning_level }} core-tests: @@ -415,7 +412,7 @@ jobs: additional_pip_packages_post: ${{ needs.default-dependency-versions.outputs.pennylane-lightning-latest }} pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: core and not qcut and not finite-diff and not param-shift - pytest_additional_args: --splits 6 --group ${{ matrix.group }} + pytest_additional_args: --splits 6 --group ${{ matrix.group }} -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} pytest_durations_file_path: '.github/durations/core_tests_durations.json' requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'core.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} @@ -454,9 +451,9 @@ jobs: additional_pip_packages_post: ${{ needs.default-dependency-versions.outputs.pennylane-lightning-latest }} pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: all_interfaces + pytest_additional_args: -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'all_interfaces.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} - python_warning_level: ${{ inputs.python_warning_level }} external-libraries-tests: @@ -486,6 +483,7 @@ jobs: python_version: ${{ matrix.python-version }} pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: external + pytest_additional_args: -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} additional_pip_packages: | pyzx matplotlib stim quimb mitiq pennylane-qiskit ply ${{ needs.default-dependency-versions.outputs.jax-version }} @@ -501,7 +499,6 @@ jobs: requirements_file: ${{ github.event_name == 'schedule' && strategy.job-index == 0 && 'external.txt' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} - python_warning_level: ${{ inputs.python_warning_level }} qcut-tests: @@ -531,6 +528,7 @@ jobs: python_version: ${{ matrix.python-version }} pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: qcut + pytest_additional_args: -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} additional_pip_packages: | kahypar==1.1.7 opt_einsum @@ -540,7 +538,6 @@ jobs: ${{ inputs.additional_python_packages }} additional_pip_packages_post: ${{ needs.default-dependency-versions.outputs.pennylane-lightning-latest }} disable_new_opmath: ${{ inputs.disable_new_opmath }} - python_warning_level: ${{ inputs.python_warning_level }} qchem-tests: @@ -572,11 +569,11 @@ jobs: additional_pip_packages_post: ${{ needs.default-dependency-versions.outputs.pennylane-lightning-latest }} pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: qchem + pytest_additional_args: -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} additional_pip_packages: | openfermionpyscf basis-set-exchange ${{ inputs.additional_python_packages }} disable_new_opmath: ${{ inputs.disable_new_opmath }} - python_warning_level: ${{ inputs.python_warning_level }} gradients-tests: needs: @@ -614,8 +611,8 @@ jobs: additional_pip_packages_post: ${{ needs.default-dependency-versions.outputs.pennylane-lightning-latest }} pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: ${{ matrix.config.suite }} + pytest_additional_args: -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} - python_warning_level: ${{ inputs.python_warning_level }} data-tests: @@ -646,11 +643,11 @@ jobs: additional_pip_packages_post: ${{ needs.default-dependency-versions.outputs.pennylane-lightning-latest }} pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} pytest_markers: data + pytest_additional_args: -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} additional_pip_packages: | h5py ${{ inputs.additional_python_packages }} disable_new_opmath: ${{ inputs.disable_new_opmath }} - python_warning_level: ${{ inputs.python_warning_level }} device-tests: @@ -693,9 +690,8 @@ jobs: additional_pip_packages_post: ${{ needs.default-dependency-versions.outputs.pennylane-lightning-latest }} pytest_test_directory: pennylane/devices/tests pytest_coverage_flags: ${{ inputs.pytest_coverage_flags }} - pytest_additional_args: --device=${{ matrix.config.device }} --shots=${{ matrix.config.shots }} + pytest_additional_args: --device=${{ matrix.config.device }} --shots=${{ matrix.config.shots }} -W ${{ inputs.python_warning_level }} ${{ inputs.python_warning_level != 'default' && '--continue-on-collection-errors' || '' }} disable_new_opmath: ${{ inputs.disable_new_opmath }} - python_warning_level: ${{ inputs.python_warning_level }} upload-to-codecov: From a70865b42e2bb1dcaf10edd090f13768b96196f3 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 24 Oct 2024 11:44:13 -0400 Subject: [PATCH 65/82] Fix duplicate pytest filter --- tests/pytest.ini | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/pytest.ini b/tests/pytest.ini index 527ae65fcc5..2cdb4b8ef8f 100644 --- a/tests/pytest.ini +++ b/tests/pytest.ini @@ -33,5 +33,3 @@ filterwarnings = ignore:PauliWord.hamiltonian:pennylane.PennyLaneDeprecationWarning addopts = --benchmark-disable xfail_strict=true -filterwarnings = - error::pennylane.PennyLaneDeprecationWarning From 0fbff298edcb9e38f75907d52026f5d8d0cb132a Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Thu, 24 Oct 2024 15:01:24 -0400 Subject: [PATCH 66/82] Cancel in progress disabled --- .github/workflows/package_warnings_as_errors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index ddf43c256b2..52881218294 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -16,7 +16,7 @@ on: concurrency: group: warnings-as-errors-tests-${{ github.ref }} - cancel-in-progress: true + cancel-in-progress: false jobs: test-warnings-as-errors: From fc3b52cdb713815c2c9a52b2e0024e4f3b96669e Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 08:54:22 -0400 Subject: [PATCH 67/82] Attempt to add ff to matrix strategy --- .github/workflows/interface-unit-tests.yml | 86 +++++++++++++++++++++- 1 file changed, 85 insertions(+), 1 deletion(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index bf99c44b47c..6d9031c7d84 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -94,6 +94,30 @@ jobs: default_runner: ubuntu-latest force_large_runner: ${{ inputs.use_large_runner }} + disable-fail-fast-wae: + steps: + - name: Set fail-fast for WAE + id: mat_fail_fast + run: | + if [ "${{ inputs.python_warning_level }}" == "true" ]; + then + cat >python_warning_level.json <<-EOF + { + "matrix-fail-fast": "default" + } + EOF + else + cat >python_warning_level.json <<-EOF + { + "matrix-fail-fast": "error" + } + EOF + fi + echo "fail_fast=$(jq -r tostring python_warning_level.json)" >> $GITHUB_OUTPUT + + outputs: + matrix-fail-fast: ${{ steps.mat_fail_fast.outputs.fail_fast }} + setup-ci-load: needs: - determine_runner @@ -243,7 +267,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).torch-tests @@ -279,7 +308,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).autograd-tests @@ -312,7 +346,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).tf-tests @@ -325,6 +364,7 @@ jobs: fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests || fromJSON(needs.setup-ci-load.outputs.python-version).default }} + fail-fast: ${{ inputs.python_warning_level != 'default' && 'false' || 'true' }} if: ${{ !contains(fromJSON(needs.setup-ci-load.outputs.jobs-to-skip), 'tf-tests') }} uses: ./.github/workflows/unit-test.yml with: @@ -349,7 +389,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).jax-tests @@ -387,8 +432,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: - max-parallel: >- + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).core-tests || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default @@ -423,7 +472,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).all-interfaces-tests @@ -461,7 +515,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).external-libraries-tests @@ -506,7 +565,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).qcut-tests @@ -545,7 +609,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).qchem-tests @@ -580,7 +649,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).gradients-tests @@ -620,7 +694,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).data-tests @@ -655,7 +734,12 @@ jobs: - setup-ci-load - determine_runner - default-dependency-versions + - disable-fail-fast-wae strategy: + fail-fast: >- + ${{ + fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).device-tests From 0f74ea2abb14fedc57412307ebbc5549dbfb5231 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 08:59:07 -0400 Subject: [PATCH 68/82] Fix syntax error --- .github/workflows/interface-unit-tests.yml | 28 ++++++++++++---------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 6d9031c7d84..2b6a08fdf03 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -95,6 +95,7 @@ jobs: force_large_runner: ${{ inputs.use_large_runner }} disable-fail-fast-wae: + runs-on: ${{ needs.determine_runner.outputs.runner_group }} steps: - name: Set fail-fast for WAE id: mat_fail_fast @@ -271,7 +272,7 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" }} max-parallel: >- ${{ @@ -312,7 +313,7 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" }} max-parallel: >- ${{ @@ -350,7 +351,7 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" }} max-parallel: >- ${{ @@ -393,7 +394,7 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" }} max-parallel: >- ${{ @@ -436,8 +437,9 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" - }} max-parallel: >- + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + }} + max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).core-tests || fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).default @@ -476,7 +478,7 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" }} max-parallel: >- ${{ @@ -519,7 +521,7 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" }} max-parallel: >- ${{ @@ -569,7 +571,7 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" }} max-parallel: >- ${{ @@ -613,7 +615,7 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" }} max-parallel: >- ${{ @@ -653,7 +655,7 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" }} max-parallel: >- ${{ @@ -698,7 +700,7 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" }} max-parallel: >- ${{ @@ -738,7 +740,7 @@ jobs: strategy: fail-fast: >- ${{ - fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast) == "default" && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" }} max-parallel: >- ${{ From 3fb486813127d22f829ad8a9209bbc10692a9a43 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 09:02:07 -0400 Subject: [PATCH 69/82] +1 --- .github/workflows/interface-unit-tests.yml | 24 +++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 2b6a08fdf03..02c7301d898 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -272,7 +272,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ @@ -313,7 +313,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ @@ -351,7 +351,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ @@ -394,7 +394,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ @@ -437,7 +437,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ @@ -478,7 +478,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ @@ -521,7 +521,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ @@ -571,7 +571,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ @@ -615,7 +615,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ @@ -655,7 +655,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ @@ -700,7 +700,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ @@ -740,7 +740,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && "true" || "false" + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false }} max-parallel: >- ${{ From 6534b52c709ccd5ac581d48c4a4dcdb8995f53c7 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 09:03:27 -0400 Subject: [PATCH 70/82] Remove runs on attribute --- .github/workflows/interface-unit-tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 02c7301d898..c55eca0e9a5 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -95,7 +95,6 @@ jobs: force_large_runner: ${{ inputs.use_large_runner }} disable-fail-fast-wae: - runs-on: ${{ needs.determine_runner.outputs.runner_group }} steps: - name: Set fail-fast for WAE id: mat_fail_fast From dd9dc4c4d3560e7f2b47f116e72835d028723fc9 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 09:04:58 -0400 Subject: [PATCH 71/82] Readd runner group --- .github/workflows/interface-unit-tests.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index c55eca0e9a5..c7ae4544916 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -95,6 +95,10 @@ jobs: force_large_runner: ${{ inputs.use_large_runner }} disable-fail-fast-wae: + needs: + - determine_runner + + runs-on: ${{ needs.determine_runner.outputs.runner_group }} steps: - name: Set fail-fast for WAE id: mat_fail_fast From 589adfb9d3f8dd3629d7a52831da8fbb441ad163 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 09:45:28 -0400 Subject: [PATCH 72/82] Change boolean value to string --- .github/workflows/interface-unit-tests.yml | 26 +++++++++++----------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index c7ae4544916..b9f6a528bfe 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -275,7 +275,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' }} max-parallel: >- ${{ @@ -316,7 +316,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' }} max-parallel: >- ${{ @@ -354,7 +354,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' }} max-parallel: >- ${{ @@ -397,7 +397,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' }} max-parallel: >- ${{ @@ -440,8 +440,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).core-tests @@ -481,7 +481,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' }} max-parallel: >- ${{ @@ -524,7 +524,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' }} max-parallel: >- ${{ @@ -574,7 +574,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' }} max-parallel: >- ${{ @@ -618,7 +618,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' }} max-parallel: >- ${{ @@ -658,7 +658,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' }} max-parallel: >- ${{ @@ -703,7 +703,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' }} max-parallel: >- ${{ @@ -743,7 +743,7 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && true || false + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' }} max-parallel: >- ${{ From 2a4451f712053117fbeb78db11fb68c5b9609e62 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 10:04:16 -0400 Subject: [PATCH 73/82] eval TF outside conditional --- .github/workflows/interface-unit-tests.yml | 49 +++++++++++----------- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index b9f6a528bfe..385d1268034 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -275,8 +275,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).torch-tests @@ -316,8 +316,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).autograd-tests @@ -354,8 +354,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).tf-tests @@ -368,7 +368,6 @@ jobs: fromJSON(needs.setup-ci-load.outputs.python-version).tf-tests || fromJSON(needs.setup-ci-load.outputs.python-version).default }} - fail-fast: ${{ inputs.python_warning_level != 'default' && 'false' || 'true' }} if: ${{ !contains(fromJSON(needs.setup-ci-load.outputs.jobs-to-skip), 'tf-tests') }} uses: ./.github/workflows/unit-test.yml with: @@ -397,8 +396,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).jax-tests @@ -440,8 +439,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).core-tests @@ -481,8 +480,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).all-interfaces-tests @@ -524,8 +523,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).external-libraries-tests @@ -574,8 +573,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).qcut-tests @@ -618,8 +617,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).qchem-tests @@ -658,8 +657,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).gradients-tests @@ -703,8 +702,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).data-tests @@ -743,8 +742,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} && 'true' || 'false' max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).device-tests From 148384464b08ac22ba8ad24a1b3388ac87bdadd7 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 10:09:32 -0400 Subject: [PATCH 74/82] Remove bool string and use contains directly --- .github/workflows/interface-unit-tests.yml | 48 +++++++++++----------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 385d1268034..6af6fcc55a4 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -275,8 +275,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).torch-tests @@ -316,8 +316,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).autograd-tests @@ -354,8 +354,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).tf-tests @@ -396,8 +396,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).jax-tests @@ -439,8 +439,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).core-tests @@ -480,8 +480,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).all-interfaces-tests @@ -523,8 +523,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).external-libraries-tests @@ -573,8 +573,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).qcut-tests @@ -617,8 +617,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).qchem-tests @@ -657,8 +657,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).gradients-tests @@ -702,8 +702,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).data-tests @@ -742,8 +742,8 @@ jobs: strategy: fail-fast: >- ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} && 'true' || 'false' + contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' + }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).device-tests From de17cd7ceb93d719e908845a3ce7141874eba391 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 10:13:07 -0400 Subject: [PATCH 75/82] Fix WAE steps --- .github/workflows/interface-unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 6af6fcc55a4..524e4be341b 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -103,7 +103,7 @@ jobs: - name: Set fail-fast for WAE id: mat_fail_fast run: | - if [ "${{ inputs.python_warning_level }}" == "true" ]; + if [ "${{ contains(inputs.python_warning_level, "default") }}" ]; then cat >python_warning_level.json <<-EOF { From 01180ec13150de384b35d60b39fd38d9f82df354 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 10:14:13 -0400 Subject: [PATCH 76/82] +1 --- .github/workflows/interface-unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 524e4be341b..c46bbf92c3e 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -103,7 +103,7 @@ jobs: - name: Set fail-fast for WAE id: mat_fail_fast run: | - if [ "${{ contains(inputs.python_warning_level, "default") }}" ]; + if [ "${{ contains(inputs.python_warning_level, 'default') }}" ]; then cat >python_warning_level.json <<-EOF { From 6e37430e0687e4839a83231a4247e050d1e56aa9 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 11:55:09 -0400 Subject: [PATCH 77/82] Fail fast eval --- .github/workflows/interface-unit-tests.yml | 60 +++++----------------- 1 file changed, 12 insertions(+), 48 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index c46bbf92c3e..39aac6ee485 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -273,10 +273,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).torch-tests @@ -314,10 +311,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).autograd-tests @@ -352,10 +346,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).tf-tests @@ -394,10 +385,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).jax-tests @@ -437,10 +425,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).core-tests @@ -478,10 +463,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).all-interfaces-tests @@ -521,10 +503,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).external-libraries-tests @@ -571,10 +550,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).qcut-tests @@ -615,10 +591,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).qchem-tests @@ -655,10 +628,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).gradients-tests @@ -700,10 +670,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).data-tests @@ -740,10 +707,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: >- - ${{ - contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') && 'true' || 'false' - }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).device-tests From debc1f9fdff167148962f04230377bea76964929 Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Fri, 25 Oct 2024 14:57:59 -0400 Subject: [PATCH 78/82] Disable WAE on PRs [skip ci]] --- .github/workflows/package_warnings_as_errors.yml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.github/workflows/package_warnings_as_errors.yml b/.github/workflows/package_warnings_as_errors.yml index 52881218294..8bd97aed2e3 100644 --- a/.github/workflows/package_warnings_as_errors.yml +++ b/.github/workflows/package_warnings_as_errors.yml @@ -4,15 +4,6 @@ on: schedule: - cron: '35 2 * * 0' workflow_dispatch: - push: - branches: - - master - pull_request: - types: - - opened - - reopened - - synchronize - - ready_for_review concurrency: group: warnings-as-errors-tests-${{ github.ref }} From dcaa531f14cb3e42e8d29d3f769d92fe4f3d1875 Mon Sep 17 00:00:00 2001 From: Lee James O'Riordan Date: Wed, 30 Oct 2024 10:00:15 -0400 Subject: [PATCH 79/82] Update .github/workflows/interface-unit-tests.yml Co-authored-by: Rashid N H M <95639609+rashidnhm@users.noreply.github.com> --- .github/workflows/interface-unit-tests.yml | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 39aac6ee485..a87a72bc715 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -103,21 +103,7 @@ jobs: - name: Set fail-fast for WAE id: mat_fail_fast run: | - if [ "${{ contains(inputs.python_warning_level, 'default') }}" ]; - then - cat >python_warning_level.json <<-EOF - { - "matrix-fail-fast": "default" - } - EOF - else - cat >python_warning_level.json <<-EOF - { - "matrix-fail-fast": "error" - } - EOF - fi - echo "fail_fast=$(jq -r tostring python_warning_level.json)" >> $GITHUB_OUTPUT + echo "fail_fast=${{ contains(inputs.python_warning_level, 'default') && 'default' || 'error' }}" >> $GITHUB_OUTPUT outputs: matrix-fail-fast: ${{ steps.mat_fail_fast.outputs.fail_fast }} From 6e70178c942595638b62766e4fb6cc8d4823da2f Mon Sep 17 00:00:00 2001 From: "Lee J. O'Riordan" Date: Wed, 30 Oct 2024 10:02:32 -0400 Subject: [PATCH 80/82] Simplify fail fast --- .github/workflows/interface-unit-tests.yml | 26 +++++++++++----------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index a87a72bc715..a53f4cfa445 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -106,7 +106,7 @@ jobs: echo "fail_fast=${{ contains(inputs.python_warning_level, 'default') && 'default' || 'error' }}" >> $GITHUB_OUTPUT outputs: - matrix-fail-fast: ${{ steps.mat_fail_fast.outputs.fail_fast }} + fail_fast: ${{ steps.mat_fail_fast.outputs.fail_fast }} setup-ci-load: needs: @@ -259,7 +259,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).torch-tests @@ -297,7 +297,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).autograd-tests @@ -332,7 +332,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).tf-tests @@ -371,7 +371,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).jax-tests @@ -411,7 +411,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).core-tests @@ -449,7 +449,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).all-interfaces-tests @@ -489,7 +489,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).external-libraries-tests @@ -536,7 +536,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).qcut-tests @@ -577,7 +577,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).qchem-tests @@ -614,7 +614,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).gradients-tests @@ -656,7 +656,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).data-tests @@ -693,7 +693,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.matrix-fail-fast), 'default') }} + fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).device-tests From f5b883c2d0bf700feb50dd09ae78a769c59cadb9 Mon Sep 17 00:00:00 2001 From: Lee James O'Riordan Date: Fri, 8 Nov 2024 09:55:42 -0500 Subject: [PATCH 81/82] Update .github/workflows/interface-unit-tests.yml Co-authored-by: Rashid N H M <95639609+rashidnhm@users.noreply.github.com> --- .github/workflows/interface-unit-tests.yml | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index a53f4cfa445..4ced3cefc92 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -132,17 +132,8 @@ jobs: then cat >python_versions.json <<-EOF { - "default": ["3.10"], - "torch-tests": ["3.10"], - "tf-tests": ["3.10"], - "jax-tests": ["3.10"], - "all-interfaces-tests": ["3.10"], - "external-libraries-tests": ["3.10"], - "qcut-tests": ["3.10"], - "qchem-tests": ["3.10"], - "gradients-tests": ["3.10"], - "data-tests": ["3.10"], - "device-tests": ["3.10"] } + "default": ["3.10"] + } EOF else cat >python_versions.json <<-EOF From 2773ab46d570fd1ef8c671763f46641313398eae Mon Sep 17 00:00:00 2001 From: Lee James O'Riordan Date: Fri, 8 Nov 2024 09:56:00 -0500 Subject: [PATCH 82/82] Update .github/workflows/interface-unit-tests.yml Co-authored-by: Rashid N H M <95639609+rashidnhm@users.noreply.github.com> --- .github/workflows/interface-unit-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/interface-unit-tests.yml b/.github/workflows/interface-unit-tests.yml index 4ced3cefc92..9952ca1d153 100644 --- a/.github/workflows/interface-unit-tests.yml +++ b/.github/workflows/interface-unit-tests.yml @@ -250,7 +250,7 @@ jobs: - default-dependency-versions - disable-fail-fast-wae strategy: - fail-fast: ${{ contains(fromJSON(needs.disable-fail-fast-wae.outputs.fail_fast), 'default') }} + fail-fast: ${{ needs.disable-fail-fast-wae.outputs.fail_fast == 'default' }} max-parallel: >- ${{ fromJSON(needs.setup-ci-load.outputs.matrix-max-parallel).torch-tests