perldelta for 91e15e585c79, reinstate apostrophe package separator #22730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeenan
requested changes
Nov 11, 2024
pod/perldelta.pod
Outdated
| Note that disabling this feature only prevents use of apostrophe as a | ||
| package separator within code, unlike with the reverted removal | ||
| symbolic references still treat C<'> as C<::> with the feature | ||
| disabled: |
There was a problem hiding this comment.
I'm confused by the flow of the previous sentence. Should it be unlike with the reverted removal of symbolic references ...? Or perhaps, unlike with the reverted removal, symbolic references ...
There was a problem hiding this comment.
removed the mention of the reverted removal
tonycoz
force-pushed
the
22675-apos-in-name-perldelta
branch
from
3888e10
to
22329c8
Compare
jkeenan
requested changes
Nov 12, 2024
I don't see any comment pointing out that nit. |
jkeenan
reviewed
Nov 12, 2024
pod/perldelta.pod
Outdated
| no feature "apostrophe_as_package_separator"; | ||
|
|
||
| Note that disabling this feature only prevents use of apostrophe as a | ||
| package separator within code, symbolic references still treat C<'> as |
There was a problem hiding this comment.
s/code,/code;/
Semicolon better to separate two independent clauses. (Somehow this didn't get posted earlier.)
There was a problem hiding this comment.
TIL, I only remembered ; to separate colon introduced lists, I didn't know (perhaps forget) the independent clauses use.
tonycoz
force-pushed
the
22675-apos-in-name-perldelta
branch
from
22329c8
to
5360af9
Compare
tonycoz
force-pushed
the
22675-apos-in-name-perldelta
branch
from
5360af9
to
72854d8
Compare
|
Moved the change to |
It's in incompatible changes, it doesn't really belong in Core Enhancements.
tonycoz
force-pushed
the
22675-apos-in-name-perldelta
branch
from
72854d8
to
0488277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's in incompatible changes, it doesn't really belong in Core Enhancements.