Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Galileo #9

Open
emiedmee opened this issue Apr 25, 2023 · 2 comments · May be fixed by #8
Open

Support for Galileo #9

emiedmee opened this issue Apr 25, 2023 · 2 comments · May be fixed by #8

Comments

@emiedmee
Copy link

I've been working with the Quectel RM500Q-GL module, which has a GNSS engine and can output NMEA sentences.
I found your project and it almost fit my needs, except that I'm not using GLONASS but a combination of GPS and Galileo.
So I've decided to add Galileo support next to GPS and GLONASS in your project.
This has been tested with several files containing various states of NMEA sentences and all issues, including issues in the original code, should be fixed with PR #8 .
I've also made all the code comply more with Python coding guidlines using linters, etc.

I hope you like my work!

@emiedmee emiedmee linked a pull request Apr 25, 2023 that will close this issue
@nabelekt
Copy link
Member

Hey, @emiedmee. Thanks for you contributions. I don't use this code any more (moved away from NMEA for my project), but will try to pull your branches soon and test them out. If things look good, I'll probably go ahead and merge. Thanks!

@emiedmee
Copy link
Author

Thanks!
When testing 'add-galileo' it might be possible you run into issues when exporting to the database, because I had some issues there. That's the reason why I made the other PR.
So you might want to merge both branches first to test the database part or use my master branch (where I merged them already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants