Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define code ownership using "OWNERS" files in the central CI config repo #2974

Open
1 of 7 tasks
wuhuizuo opened this issue May 24, 2024 · 0 comments
Open
1 of 7 tasks
Assignees
Labels
enhancement New feature or request

Comments

@wuhuizuo
Copy link
Collaborator

wuhuizuo commented May 24, 2024

In order to improve the code review process and ensure that changes are reviewed by the appropriate people, we propose using "OWNERS" files to define code ownership in our central CI config repository. This repository contains Jenkins pipelines, shell scripts, and Jenkins job DSL files that are used across multiple development teams.

By defining code ownership using "OWNERS" files, we can:

Ensure that changes are reviewed by the appropriate developers who are familiar with the codebase
Reduce the burden on individual maintainers to review all changes
Improve the quality of the codebase by ensuring that changes receive appropriate scrutiny
We propose creating an "OWNERS" file for each subdirectory in the repository that corresponds to a different team or area of the codebase. Each "OWNERS" file will contain the GitHub usernames or team names of the developers who are responsible for that code.

We also propose configuring our CI system to enforce the use of "OWNERS" files. This means that pull requests will not be able to be merged until they have been approved by at least one owner of the affected code.

We encourage all development teams to review this proposal and provide feedback. We also ask that each team review their respective codebase and provide a list of owners who should be added to the corresponding "OWNERS" file.

Thank you for your time and consideration.


Some tasks need to be finished:

  • setup "OWNERS" files for documents CI files. #2975
  • setup "OWNERS" files for TiDB CI files.
  • setup "OWNERS" files for TiFlow CI files.
  • setup "OWNERS" files for TiFlash CI files.
  • setup "OWNERS" files for PD CI files.
  • setup "OWNERS" files for TiKV CI files.
  • more...
@wuhuizuo wuhuizuo added the enhancement New feature or request label May 24, 2024
@wuhuizuo wuhuizuo self-assigned this May 24, 2024
wuhuizuo added a commit that referenced this issue May 24, 2024
wuhuizuo added a commit that referenced this issue May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant