Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add Support for React 19 Compatibility in Plasmo #1141

Open
3 of 4 tasks
sashamorozov opened this issue Dec 2, 2024 · 2 comments
Open
3 of 4 tasks

[RFC] Add Support for React 19 Compatibility in Plasmo #1141

sashamorozov opened this issue Dec 2, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@sashamorozov
Copy link

How do you envision this feature/change to look/work like?

Plasmo should work with React 19 without blocking updates due to version checks. Right now, the framework checks for a specific React version and fails if React 19 is used. Additionally, there is no folder or template similar to cli/plasmo/templates/static/react18, which would make it easier to support the new version.

The idea is to remove or loosen the version checks and add a React 19-specific folder/template if needed.

What is the purpose of this change/feature? Why?

The lack of support for React 19 prevents developers from upgrading to the latest React version. This blocks access to new features, better performance, and long-term updates, making projects feel stuck on older versions.

Adding support would let developers upgrade without worries and keep their projects modern.

(OPTIONAL) Example implementations

  1. Remove or update the React version checks to support React 19
  2. Add a react19 folder/template, similar to the existing react18 folder in cli/plasmo/templates/static/
  3. ...

(OPTIONAL) Contribution

  • I would like to contribute to this RFC via a PR

Verify canary release

  • I verified that the issue exists in plasmo canary release

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I checked the current issues for duplicate problems.
@sashamorozov sashamorozov added the enhancement New feature or request label Dec 2, 2024
@PawelGawlikDev
Copy link

@louisgv Any update about it?

@nahtnam
Copy link
Contributor

nahtnam commented Dec 16, 2024

Having this issue too. Specifically the error I get is "No supported UI library found". In case anyone else is searching the repo for this message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants