Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add containerTransactionsLookup API method (#91) #480

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add containerTransactionsLookup API method (#91) #480

wants to merge 8 commits into from
+131 −1

Conversation

takejohn
Copy link
Contributor

@takejohn takejohn commented Dec 31, 2023 •
edited
Loading

I want to add the feature suggested as #91, container transactions lookup.

Additions

New methods:

int parseResult(String[] results).getAmount()
ItemMeta parseResult(String[] results).getItemMeta()
List<String[]> containerTransactionsLookup(Location location, int time)

Changes

parseResult(String[] results).getBlockData() will return the BlockData of the item if the material is a block.

@takejohn
Copy link
Contributor Author

Should I add documentation as /docs/api/version/v10.md?

@takejohn takejohn marked this pull request as ready for review December 31, 2023 09:51
@vanquesh
Copy link

It would be great to get this added

@stale Stale
Copy link

stale bot commented Mar 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 30, 2024
@Intelli Intelli removed the stale label Mar 30, 2024
@stale Stale
Copy link

stale bot commented May 30, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 30, 2024
notfoundname added a commit to notfoundname/CoreProtect that referenced this pull request Jun 4, 2024
@notfoundname
https://github.com/PlayPro/CoreProtect/pull/480
fb52bfb
@stale stale bot closed this Jun 7, 2024
@Intelli Intelli reopened this Jun 7, 2024
@stale stale bot removed the stale label Jun 7, 2024
notfoundname
notfoundname reviewed Jun 10, 2024
View reviewed changes
src/main/java/net/coreprotect/CoreProtectAPI.java
return 0;
}

return Integer.parseInt(parse[10]);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can throw NumberFormatException

@stale Stale
Copy link

stale bot commented Aug 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 10, 2024
@Intelli Intelli removed the stale label Aug 10, 2024
@stale Stale
Copy link

stale bot commented Oct 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 17, 2024
@Intelli Intelli removed the stale label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notfoundname notfoundname notfoundname left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@takejohn @vanquesh @notfoundname @Intelli