-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grade_nDims
sum is only checked at construction
#48
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
grade_dims
add up tonDims
condition is only checked in the settings at construction. This may lead to incongruent settings, provided thegrade_dims
is altered after construction.This error condition is checked twice: once in settings and once in
_pypolychord.cpp
.It may be prudent to either expand the error checking to be done early, at construction of the settings object, or to move it entirely into the
run_polychord
method (see #47 ).The text was updated successfully, but these errors were encountered: