Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fraction output from PID does not properly translate to milliseconds #187

Open
PoorRican opened this issue May 16, 2023 · 1 comment
Open

Fraction output from PID does not properly translate to milliseconds #187

PoorRican opened this issue May 16, 2023 · 1 comment
Labels
bug Something isn't working
Milestone
Verified PID Cont...

Comments

@PoorRican
Copy link
Owner

  • 0.1 should be equal to Duration::milliseconds(100)
  • 0.999 should translate to Duration::milliseconds(999)
@PoorRican PoorRican moved this to 🔖 Ready in 0.1.0-beta Release May 16, 2023
@PoorRican PoorRican added this to the Verified PID Controller milestone Jul 20, 2023
@PoorRican
Copy link
Owner Author

Theoretically, this does not stop proper PID function. This is neither a bug in Device but rather a bug in PID::calculate(). The priority for now will remain on being implementation of HW libraries and API ease.

@PoorRican PoorRican added the bug Something isn't working label Jul 21, 2023
@PoorRican PoorRican changed the title Float fractional part should properly translate to milliseconds Fraction output from PID does not properly translate to milliseconds Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
0.1.0-beta Release
Status: 🔖 Ready
Milestone
Verified PID Controller
Development

No branches or pull requests
1 participant
@PoorRican