Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Each Group should have dedicated settings #24

Closed
PoorRican opened this issue Feb 10, 2023 · 4 comments · Fixed by #176
Closed

Each Group should have dedicated settings #24

PoorRican opened this issue Feb 10, 2023 · 4 comments · Fixed by #176
Labels
enhancement New feature or request

Comments

@PoorRican
Copy link
Owner

Instead of using ".dotenv" crate, manually read from a TOML file named as the PollGroup, if no file exists, then implement a load_or_new(&path) function and load default.
@PoorRican PoorRican converted this from a draft issue Feb 10, 2023
@PoorRican PoorRican added the enhancement New feature or request label Feb 10, 2023
@PoorRican PoorRican moved this from 💡 Ideas to 🗓 Backlog in 6SENS Base Features Mar 2, 2023
@PoorRican PoorRican moved this to 🆕 New in 0.1.0-beta Release May 7, 2023
@PoorRican PoorRican moved this from 🆕 New to 🔖 Ready in 0.1.0-beta Release May 7, 2023
@PoorRican
Copy link
Owner Author

A new struct GlobalConfig should store properties such as root dir

@PoorRican PoorRican moved this from 🔖 Ready to 🏗 In progress in 0.1.0-beta Release May 7, 2023
@PoorRican PoorRican moved this from 🏗 In progress to 🔖 Ready in 0.1.0-beta Release May 7, 2023
@PoorRican PoorRican mentioned this issue May 8, 2023
Closed
@PoorRican
Copy link
Owner Author

See #165 about moving parameters out of Settings

@PoorRican PoorRican moved this from 🔖 Ready to 🏗 In progress in 0.1.0-beta Release May 10, 2023
@PoorRican
Copy link
Owner Author

The only field that any Group would need is root directory. As per #165, interval has been moved into Group.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 0.1.0-beta Release May 10, 2023
@github-project-automation github-project-automation bot moved this from 🗓 Backlog to ✅ Done in 6SENS Base Features May 10, 2023
@PoorRican PoorRican changed the title Each PollGroup should have dedicated settings Each Group should have dedicated settings May 10, 2023
@PoorRican
Copy link
Owner Author

See #167 for storing as TOML. See #168 and #169 for root_path setting

@PoorRican PoorRican moved this from ✅ Done to 👀 In review in 0.1.0-beta Release May 10, 2023
PoorRican added a commit that referenced this issue May 11, 2023
@PoorRican
Each Group should have dedicated settings #24
578d5b8
@PoorRican PoorRican mentioned this issue May 12, 2023
Merged
@PoorRican PoorRican moved this from 👀 In review to ✅ Done in 0.1.0-beta Release May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
0.1.0-beta Release
Status: ✅ Done
6SENS Base Features
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Group PoorRican/sensd
1 participant
@PoorRican