auth: don't crash when a catalog SOA is invalid

PowerDNS · Apr 10, 2024 · e7bb966 · e7bb966
1 parent 8eb3d9e
commit e7bb966
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/pdns/auth-primarycommunicator.cc b/pdns/auth-primarycommunicator.cc
@@ -157,16 +157,21 @@ void CommunicatorClass::getUpdatedProducers(UeberBackend* B, vector<DomainInfo>&
           continue;
         }
 
-        B->setDomainMetadata(di.zone, "CATALOG-HASH", mapHash);
-
-        g_log << Logger::Warning << "new CATALOG-HASH '" << mapHash << "' for zone '" << di.zone << "'" << endl;
-
         SOAData sd;
-        if (!B->getSOAUncached(di.zone, sd)) {
-          g_log << Logger::Warning << "SOA lookup failed for producer zone '" << di.zone << "'" << endl;
+        try {
+          if (!B->getSOAUncached(di.zone, sd)) {
+            g_log << Logger::Warning << "SOA lookup failed for producer zone '" << di.zone << "'" << endl;
+            continue;
+          }
+        }
+        catch (...) {
           continue;
         }
 
+        g_log << Logger::Warning << "new CATALOG-HASH '" << mapHash << "' for zone '" << di.zone << "'" << endl;
+
+        B->setDomainMetadata(di.zone, "CATALOG-HASH", mapHash);
+
         DNSResourceRecord rr;
         makeIncreasedSOARecord(sd, "EPOCH", "", rr);
         di.backend->startTransaction(sd.qname, -1);

diff --git a/pdns/backends/gsql/gsqlbackend.cc b/pdns/backends/gsql/gsqlbackend.cc
@@ -463,7 +463,7 @@ void GSQLBackend::getUnfreshSecondaryInfos(vector<DomainInfo>* unfreshDomains)
         continue;
       }
       catch (...) {
-        g_log << Logger::Warning << __PRETTY_FUNCTION__ << " error while parsing SOA data for zone '" << di.zone << endl;
+        g_log << Logger::Warning << __PRETTY_FUNCTION__ << " error while parsing SOA data for zone '" << di.zone << "'" << endl;
         continue;
       }