Man page errata

[PenelopeFudd]

• This is not a support question, I have read about opensource and will send support questions to the IRC channel, GitHub Discussions or the mailing list.
• I have read and understood the 'out in the open' support policy

• Program: dnsdist
• Issue type: Bug report

Short description

The documentation for HTTPStatusAction() lists the options for ERCodeAction(), the preceding function on the page.

• https://dnsdist.org/reference/actions.html#HTTPStatusAction

Environment

• Operating system: n/a
• Software version: n/a
• Software source: n/a

Steps to reproduce

1. n/a

Expected behaviour

n/a

Actual behaviour

n/a

Other information

n/a

[rgacogne]

This seems a bit trickier than I initially expected. The documentation is not wrong: the action actually takes the documented values and tries to apply to them to DNS payload. But it does not really make sense because 1/ it applies it to the query payload, while the HTTP response body is not stored there, and 2/ because even for a 200 response where we can expect the response to be a DNS payload IF the content-type is set to application/dns-message, I don't see why the caller would want this since they are already supplying the payload, and thus can set the flags they want anyway.
So I think the best course of action would be to stop doing anything with these options and deprecate them in the documentation. We cannot remove them from the code right away, however, because it would potentially break existing configurations.