Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some errors in the PowerDNS Recursor documentation #14860

Open
egnun opened this issue Nov 21, 2024 · 1 comment
Open

Some errors in the PowerDNS Recursor documentation #14860

egnun opened this issue Nov 21, 2024 · 1 comment

Comments

@egnun
Copy link

egnun commented Nov 21, 2024

Hello, PowerDNS folks,

I found some errors in the documentation.

Environment

  • Operating system: GNU+Linux
  • Software version: 4.9.9
  • luajit: 2.1.1707061634
  • Software source:Operating system repository

The first errors are in the "The DNSName object":

  1. In the very first codeblock it says:
    name2:chopoff() …
    that should be:
    name2:chopOff()…

  2. Also, the print(…) statements don't seem to work
    I don't know, if I don't know enough about Lua or if I may have misconfigured something, but the print statements don't have an output in the logfile/journald.
    Replacing them with pdnslog(<stuff to print>) seems to work though.
    E.g. instead of
    print(myname:wirelength()) -- prints "17"
    just:
    pdnslog(myname:wirelength()) -- prints "17"

I've also found an error in the "Operating PowerDNS Recursor"

Here it says

"By setting logging.quiet to true …

There you are linking to the new YAML style settings, which is confusing, since it's the only time you do that.

I hope this helps.

P.S.: I would've submitted a PR with the fixes, but it seems, that you don't have your documentation in a public repo (like Nitrokey or Nextcloud have ;-)

@omoerbeek
Copy link
Member

omoerbeek commented Nov 21, 2024

  1. Correct
  2. Indeed, it us better to use pdnslog, as some supervisors like systemd tend to "hide" output.
  3. Old stytle settings are on their way out, but I agree there should be some consistency in a page.

The doc sources can be found in pdns/recursordist/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants