-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Trirank documentation X&Y #618
Comments
@lthoang is it something to be corrected? |
Based on the original paper, the code is correct. I made a mistake in the model's documentation. So we have to update the documentation accordingly. @linan1109 Thank you for pointing out this error. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For model.Triank, the document says X is for user-aspect and Y is for item-aspect.
But in the code, it should be the other way round, i.e. X for item-aspect and Y for user-aspect.
The text was updated successfully, but these errors were encountered: