Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Last swap of REMOVE_TOKEN triggers transfer to handler #28

Open
4 tasks
fabianschu opened this issue Nov 1, 2021 · 0 comments
Open
4 tasks
Assignees
Labels
feature new feature re-indexing part of the re-indexing logic

Comments

@fabianschu
Copy link
Collaborator

fabianschu commented Nov 1, 2021

User Story

As pool investor, I want residual amounts of REMOVE_TOKEN to be sent to a handler contract, so that these tokens are neither traded using unfair prices nor are they rotting in the pool.

Acceptance Criteria

  • if a token has a weight of 1% and it is flagged for removal, when it is being swapped, after the swap the residual amount of this token still in the pool is sent to a predefined address
  • the address of the handler can be set up during pool creation
  • the token is de-registered from the vault
  • the weights of the remaining tokens in the pool is adjusted

Additional Infos

  • for more specific information how the address of the handler contract should be stored and whether it should be editable, plz check the Index v1 docs
  • the simplified logic imho is: if swap occurs when weight is .5%, execute swap as usual and transfer residual amount of REMOVE_TOKEN to specified address
@fabianschu fabianschu added the re-indexing part of the re-indexing logic label Nov 1, 2021
@arseneeth arseneeth self-assigned this Nov 12, 2021
@fabianschu fabianschu assigned fabianschu and unassigned arseneeth Nov 16, 2021
@fabianschu fabianschu added the feature new feature label Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature re-indexing part of the re-indexing logic
Projects
None yet
Development

No branches or pull requests

2 participants