Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Handle pool creation w/ only two pools #38

Open
1 of 2 tasks
fabianschu opened this issue Nov 7, 2021 · 2 comments · Fixed by #55
Open
1 of 2 tasks

Chore: Handle pool creation w/ only two pools #38

fabianschu opened this issue Nov 7, 2021 · 2 comments · Fixed by #55
Assignees
Labels
enhancement New feature or request

Comments

@fabianschu
Copy link
Collaborator

fabianschu commented Nov 7, 2021

Status Quo

  • right now it is possible to create an IndexPool with only two pools from the start
  • apparently what happens internally, is that it creates a pool with the TWO_TOKEN specialization
  • for this specialization it is not possible to register further tokens with the vault after creation (TOKENS_LENGTH_MUST_BE_2), therefore it is a problem for the index pool

Acceptance Criteria

  • check if there is a straightforward way to use a general pool specialization also for two-token pools
  • if not, a validation has been added to make sure that new pools start w/ at least three tokens
@Zitzak Zitzak assigned Zitzak and unassigned Zitzak Nov 9, 2021
@Zitzak
Copy link

Zitzak commented Nov 10, 2021

As long as IndexPool inherits from BaseWeightPool it is not possible to call PoolSpecialization.GENERAL. So we decided on adding a require to make sure the pool gets created with more then 2 tokens.

@Zitzak
Copy link

Zitzak commented Nov 11, 2021

After our recent call with Index, it came up that we will look into ways of creating 2 token pools after the main issues all done. That's why I'm opening this issue again

@Zitzak Zitzak reopened this Nov 11, 2021
@fabianschu fabianschu added the enhancement New feature or request label Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants