-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRT support for MAISI #701
Open
borisfom
wants to merge
23
commits into
Project-MONAI:dev
Choose a base branch
from
borisfom:maisi-trt
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 17 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
93a4dc5
Added trt_compile configs for vista2d and vista3d
borisfom c401a63
Merge branch 'dev' of github.com:Project-MONAI/model-zoo into vista_trt
borisfom 89dfac1
Stash
borisfom c1ab420
Merge branch 'dev' into maisi-trt
borisfom 027f71b
Merge remote-tracking branch 'origin/dev' into maisi-trt
borisfom b6628fc
Working MAISI
borisfom 860b932
Merge remote-tracking branch 'origin/dev' into maisi-trt
borisfom e91ad57
Adding TRT support
borisfom b336e06
cleanup
borisfom 97d2b0e
fixing condition
borisfom 60000df
Added output_lists option
borisfom ebb50bc
update pre commit config
yiheng-wang-nv 74a6ecc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a9a8b03
update metadata
yiheng-wang-nv e827f5c
Addressing code review comments
borisfom 76f8fb6
Merge remote-tracking branch 'origin/dev' into maisi-trt
borisfom 26c0cae
Merge branch 'dev' into maisi-trt
borisfom 42fa00c
Removing dynamo repro
borisfom 94a45e0
Merge branch 'maisi-trt' of github.com:borisfom/model-zoo into maisi-trt
borisfom b4aefe0
Merge remote-tracking branch 'origin/dev' into maisi-trt
borisfom 938b6a0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 658e4f5
Fixing c_trt_args
borisfom fbfecd7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| { | ||
| "+imports": [ | ||
| "$from monai.networks import trt_compile" | ||
| ], | ||
| "c_trt_args": { | ||
| "output_lists": [ | ||
| [ | ||
| -1 | ||
| ], | ||
| [ | ||
| 0 | ||
| ] | ||
| ] | ||
| }, | ||
| "controlnet": "$trt_compile(@controlnet_def.to(@device), @trained_controlnet_path, args=@c_trt_args)", | ||
| "diffusion_unet": "$trt_compile(@diffusion_unet_def.to(@device), @trained_diffusion_path)" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @binliunls , this bundle is still use monai 1.4.0, do we need a new version here to support TRT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the dev branch for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we need a tag. CI will create a venv based on the metadata.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KumoLiu could you please help to tag a RC version of MONAI core including the TRT PR so that we can merge this one to model zoo?
Thanks in advance,
Bin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi both, I have tagged and the test is running. Once it done, I will ping you. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yiheng-wang-nv @binliunls, 1.4.1rc1 uploaded. https://pypi.org/project/monai/#history