Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample file channel names don’t match standard #133

Open
tshead opened this issue Dec 5, 2020 · 2 comments
Open

Sample file channel names don’t match standard #133

tshead opened this issue Dec 5, 2020 · 2 comments

Comments

@tshead
Copy link

tshead commented Dec 5, 2020

I’m implementing Cryptomatte support for Imagecat (https://imagecat.readthedocs.io), and noticed that the channel names in the sample files (e.g. bunny_CryptoMaterial.exr) spell out the colors:

  • uCryptoMaterial00.red
  • uCryptoMaterial00.green
  • uCryptoMaterial00.blue
  • uCryptoMaterial00.alpha

while the standard calls for single characters:

  • {typename}00.r
  • {typename}00.g
  • {typename}00.b
  • {typename}00.a

I could code around this in various ways, but what’s the right approach? It would be good to update the standard or the sample files.

Many thanks,
Tim

@cedricduriau
Copy link
Collaborator

Hi @tshead

Thanks for taking the time and effort on implementing it for Imagecat.
In which context are you using it and would like crypto for it, if I may ask out of pure curiosity?

For the Fusion implementation, this is something I specifically cover. Any channel name will be transformed to it's lowercased form, followed by a short and long form match of the respective channel names.

Cheers
Cedric

@tshead
Copy link
Author

tshead commented Feb 4, 2021

Cedric:

OK, so arguably the standard should reflect this.

My colleagues and I are using cryptomatte for experiments in machine learning, so we needed a workflow that was completely open-source for reproducibility.

Regards,
Tim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants