-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pre-commit hook with flake8 for contributors #456
Comments
I personally don't like to conflate my git workflow with my testing cycle, so I run it manually or in tox. Travis catches any issues that make it into a PR. But if you would like to submit a configuration that makes it easier for people who do want to use pre-commit hooks to do so, without encumbering those who do not, that would be fine. |
@toti1212 is the suggestion here to create, specifically, a hook definition for use with pre-commit? I think this would meet the criteria @bitglue suggests—users could use pyflakes as a pre-commit (the tool) hook, but would not be required to in any sense. I'd be happy to submit such a pull request if that's amenable! |
Hi there!
Do you think that adds a .pre-commit hook with flake8 can be useful for contributors?
The text was updated successfully, but these errors were encountered: