-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testimage.jpeg missing #34
Comments
On this note, I must stress that having code (and data and dependencies) that is mostly used in the test suite in production code, can cause a lot of maintenance harm very quickly. I would advise to make the use of |
Hi @psteinb Thanks for pointing this out! Do you have any recommendations on how to deal with this? I did not want to use a randomly generated image with numpy 1) to ensure consistency over time and 2) to check equivariance on data representing natural images rather than random noise. I also thought it was not a good idea to include images inside the library. Maybe I will try to use Thanks, |
It is hard for me to comment, as I don't know the content of But I still feel troubled that this code resides in the main def check_equivariance(self, testimage: np.ndarray, atol: float = 0.1, rtol: float = 0.1, assertion: bool = True, verbose: bool = True): Then in the |
I see your point! Thanks again for the useful advices and feedback! Gabriele |
Just wanted to run the test suite to double check #29, but then I ran into another problem:
which ocurred in
escnn/nn/modules/conv/r2convolution.py:245
(seeescnn/escnn/nn/modules/conv/r2convolution.py
Line 245 in 0972a7e
The text was updated successfully, but these errors were encountered: