Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old embedded pcre version #40

Open
leegarrett opened this issue Jun 7, 2019 · 6 comments
Open

old embedded pcre version #40

leegarrett opened this issue Jun 7, 2019 · 6 comments

Comments

@leegarrett
Copy link

src/pcre/* contains an antique pcre (3?) version, that also gets statically linked into the binary during build. I'll see if I can update it to current versions, and also change the build to preferentially use the system version.

I'll see if I can get a working PR done today.

FYI, this is (with the missing man page) the only remaining blocker for including mvdsv in Debian.

@leegarrett
Copy link
Author

This is apparently fixed in newer builds when libpcre3-dev is installed on the system.

@namtsui
Copy link

namtsui commented Aug 17, 2022

This should be reopened because the build system has moved from meson to cmake with mvdsv 0.35. cmake links against internal pcre and does not offer the option of linking against system pcre.

This might also be a blocker in OpenBSD ports, so thanks for raising this issue about using the ancient bundled pcre.

@tcsabina
Copy link
Collaborator

tcsabina commented Aug 18, 2022

You are right.
Either we should update the contained pcre, or give the option to use the system provided pcre stuff.

Willing to contribute? ;)

@tcsabina tcsabina reopened this Aug 18, 2022
@tdm4
Copy link

tdm4 commented Aug 22, 2022

@tcsabina I've added a PR #101 that searches for pcre library and links against it if found.
if you'd like to have a look? Apologies if it is pretty rough. This is my first time doing much of anything with CMake.

cc: @namtsui

@tdm4
Copy link

tdm4 commented Sep 3, 2022

@tcsabina I think PR #101 should be in a good enough state to merge now?
Let me know if I need to change anything. Thanks!

@bgermann
Copy link

pcre is abandoned. Please move to pcre2, which is pcre's successor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants