You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementation makes me wonder if in the future we should have some sort of VF2Scorer class that builds these and holds them as instance data among any other data that is reused between scorings. The reason being to encapsulate the internals of scoring without forcing client code to be aware of them (i.e. rather than threading a bunch of parameters around, we might call a VF2Scorer::score method and pass just the layout).
Oh sorry I missed your comment here back in December. I'm actually going to close this issue as it's superseded by #12276 and #12277 since we'll move all the patch logic to rust. But that's also currently blocked.
The implementation makes me wonder if in the future we should have some sort of
VF2Scorer
class that builds these and holds them as instance data among any other data that is reused between scorings. The reason being to encapsulate the internals of scoring without forcing client code to be aware of them (i.e. rather than threading a bunch of parameters around, we might call aVF2Scorer::score
method and pass just the layout).Originally posted by @kevinhartman in #11115 (review)
The text was updated successfully, but these errors were encountered: