Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor VF2 scoring rust interface #11134

Closed
mtreinish opened this issue Oct 27, 2023 · 2 comments
Closed

Refactor VF2 scoring rust interface #11134

mtreinish opened this issue Oct 27, 2023 · 2 comments
Milestone

Comments

@mtreinish
Copy link
Member

The implementation makes me wonder if in the future we should have some sort of VF2Scorer class that builds these and holds them as instance data among any other data that is reused between scorings. The reason being to encapsulate the internals of scoring without forcing client code to be aware of them (i.e. rather than threading a bunch of parameters around, we might call a VF2Scorer::score method and pass just the layout).

Originally posted by @kevinhartman in #11115 (review)

@mtreinish mtreinish added this to the 1.0.0 milestone Oct 27, 2023
@MozammilQ
Copy link
Contributor

@mtreinish , am I allowed to try this issue?

@mtreinish mtreinish modified the milestones: 1.0.0, 1.1.0 Jan 23, 2024
@jakelishman jakelishman modified the milestones: 1.1.0, 1.2.0 Apr 11, 2024
@mtreinish
Copy link
Member Author

Oh sorry I missed your comment here back in December. I'm actually going to close this issue as it's superseded by #12276 and #12277 since we'll move all the patch logic to rust. But that's also currently blocked.

@mtreinish mtreinish closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants