-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustworkx crashes immediately on Python 3.13.0b3 #1239
Comments
#1220 is not running yet so I appreciate manually testing rustworkx with the latest Python beta. I have a feeling that this is a PyO3 issue and that updating PyO3 to 0.22.x could potentially fix it. |
I'm afraid I don't really know Rust, and my quick attempts at upgrading pyo3 there failed. If there's anything you wish me to test, please let me know. |
I think we have enough information to fix on our side. You are attempting to build from source, which in general will limit the latest Python you can build with. Most of our downstream users download binaries that we build with Python 3.8 and test with 3.8 to 3.12 |
Oh, that's interesting. The stable ABI wheel (both build via |
Ah, sorry, I've just noticed the same failure in another package that worked previously, and I see that it's a regression with Python 3.13.0b3 (compared to b2). I've filed PyO3/pyo3#4309 for that. That said, if I downgrade to 3.13.0b2 some tests pass and some crash with another assertion.
That said, I think it's better to wait for the immediate issue to be fixed. If you upgraded to pyo3 0.22.0, I'd be happy to test again. |
It turns out it's a change in CPython 3.13 that PyO3 wasn't adjusted for — but since it also affects the stable ABI, CPython upstream has prepared a revert for the failing assertion, and I've confirmed that it fixes the problem with rustworkx. As for the other issues with CPython 3.13, I'm going to look into them later. However, given stable ABI, I think they'd also be CPython or PyO3 bugs. |
Thanks for finding an ABI regression on the Python interpreter! This would have been a huge headache, you caught it early on |
Information
--with-assertions
What is the current behavior?
The test suite crashes immediately after starting:
Backtrace from gdb
What is the expected behavior?
Tests passing.
Steps to reproduce the problem
--with-assertions
.rustworkx
(I've usedsetup.py build_rust -i -d
).pytest
(I've used-s
to get the error message in output).The text was updated successfully, but these errors were encountered: