Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[downloadnb-comparison] QE brand missing in all MYST downloadnbs #51

Closed
shlff opened this issue Jan 27, 2021 · 3 comments · Fixed by #432
Closed

[downloadnb-comparison] QE brand missing in all MYST downloadnbs #51

shlff opened this issue Jan 27, 2021 · 3 comments · Fixed by #432
Assignees

Comments

@shlff
Copy link
Member

shlff commented Jan 27, 2021

Hi @mmcky , the first issue I noticed by comparing downloadable notebooks from RST and MYST is that

  • the QuantEcon brand is missing in all notebooks from MYST

For example, please find a screenshot for lecture 02_multi_hyper (left: RST, right: MYST):

Screen Shot 2021-01-27 at 12 58 13 pm

It occurs in MYST because notebooks from MYST do not have the following code at the place of the brand:

<div id="qe-notebook-header" align="right" style="text-align:right;">
        <a href="https://quantecon.org/" title="quantecon.org">
                <img style="width:250px;display:inline;" width="250px" src="https://assets.quantecon.org/img/qe-menubar-logo.svg" alt="QuantEcon">
        </a>
</div>
@mmcky
Copy link
Contributor

mmcky commented Feb 1, 2021

thanks @shlff -- nice pickup.

I suspect this is due to not passing through raw html nodes.

@shlff
Copy link
Member Author

shlff commented Mar 11, 2021

@mmcky , this issue has not been solved yet.

@DrDrij DrDrij self-assigned this Mar 12, 2021
@shlff
Copy link
Member Author

shlff commented Jun 8, 2023

Thanks @mmcky and @DrDrij . (cc'd @jstac)

There is no QE brand in our downloadable notebooks. Shall we keep this style?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants