-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memestra tests are sensitive to global mutable state #61
Comments
To reproduce:
|
Maybe a dumb question, but is the cache actually necessary? It seems like if it's causing incorrect behavior then it might be reasonable to take the performance hit until there's enough testing in place to ensure that the introduction of an optimization like a cache doesn't break things. |
The cache is important, because it caches the transversal of the standard library, which is used by most modules. |
The cache needs to be isolated to the running interpreter though, not shared by any python interpreter that comes along. What about using a location for the cache that is tied to the running interpreter, instead of a system-wide cache? |
One way to do this would be to create a directory under |
This prevents subtle issues when the ast changes but gast / beniget / memestra don't get updated accordingly. Fix #61
This prevents subtle issues when the ast changes but gast / beniget / memestra don't get updated accordingly. Fix #61
This prevents subtle issues when the ast changes but gast / beniget / memestra don't get updated accordingly. Fix #61
When running tests for pythons 3.8 and 3.9 after running tests for python 3.7 without the necessary changes to
gast
andbeniget
, both to supportNamedExpr
s, the tests pass. With a clean cache (rm -rf $XDG_CONFIG_HOME/memestra
) the tests fail as they ought to. Whatever is being stored in$XDG_CONFIG_HOME
isn't taking into account enough information to make the behavior of the tool the same as it would be without a cache.The text was updated successfully, but these errors were encountered: