-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: add xml reader for espresso #1614
Labels
Comments
Thanks for pinging about this. Personally, I have no issues with it. |
@Andrew-S-Rosen @tomdemeyere What about this one? |
That seems very reasonable to me. It's on the official QEF repo (big win), it's reasonably actively maintained, it's pip installable, and it's trivial to add as an optional dependency to quacc. I have no concerns. |
Wow, nice find, I didn't know about it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What new feature would you like to see?
This would be a very simple xml reader that does nothing except parse the xml. This is nice because:
One problem: This needs "import xml.etree.ElementTree" which is known for vulnerabilities: https://docs.python.org/3/library/xml.html#xml-vulnerabilities
This should not be very problematic since we are not reading arbitrary xml files, but I would rather have your opinion before starting to work on it.
The text was updated successfully, but these errors were encountered: