-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more MLPs: ALIGN-FF, NequIP, GAP, DP, and FLARE #1940
Comments
@Andrew-S-Rosen might be working on this in the near future (when time allows). Would you prefer expanding the pick_calculator function or creating calculators for each MLP? I reckon the first approach is probably the safest. |
I'd go with the former. The only time we should create a custom calculator is if the original calculator does not have all the features we need, which is rare (right now, only VASP, Espresso, and Q-Chem require this). Expanding on the picker function seems like the easiest approach to me. It would also involve updating the as well as the Line 49 in 3ab1630
but otherwise shouldn't be too painful. |
@Andrew-S-Rosen Might see if I can get some work in. For ALIGNN-FF, would the 'default' path be best, or would you prefer to have it added as ALIGNN-FF-Default? |
@jackpm14: I'm a bit undecided. It seems there are several distinct ALIGN-FF models but I think if a user requested ALIGN-FF as the method they should get whatever is the current standard (presumably the default path). Enumerating each individual model seems like a code maintenance disaster, but having just "alignff" as the method means it may make versioning less obvious as you saw with MACE-MP-0. For now, I'd suggest just supporting "alignff" to be whatever the state of the art is at this point in time. That said, I'm very much open to suggestions here. |
What new feature would you like to see?
We already have support for MACE-MP-0, CHGNet, and M3GNet in
quacc.recipes.mlp
. We should also add support for:The text was updated successfully, but these errors were encountered: