Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slowdown of Covalent in test suite #2193

Open
Andrew-S-Rosen opened this issue May 31, 2024 · 0 comments
Open

Fix slowdown of Covalent in test suite #2193

Andrew-S-Rosen opened this issue May 31, 2024 · 0 comments
Labels
github_actions Pull requests that update GitHub Actions code good-first-issue help wanted

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented May 31, 2024 •
edited
Loading

What would you like to report?

For some reason starting in #2124, Covalent tests went from ~2 min to ~7 min in runtime. I have no clue why. I can confirm that it is indeed related to that change, as reverting the change restores the original runtime. We should fix this, but I am at a complete loss...
@Andrew-S-Rosen Andrew-S-Rosen added the github_actions Pull requests that update GitHub Actions code label May 31, 2024
@Andrew-S-Rosen Andrew-S-Rosen changed the title Covalent tests are substantially slower in the test suite Figure out why Covalent tests were substantially slower due to a seemingly unrelated PR Jun 7, 2024
@Andrew-S-Rosen Andrew-S-Rosen changed the title Figure out why Covalent tests were substantially slower due to a seemingly unrelated PR Don't try and autodetect the workfllow engine Jun 7, 2024
@Andrew-S-Rosen Andrew-S-Rosen changed the title Don't try and autodetect the workfllow engine Don't try and autodetect the workflow engine Jun 7, 2024
@Andrew-S-Rosen Andrew-S-Rosen changed the title Don't try and autodetect the workflow engine Fix slowdown of Covalent in test suite Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code good-first-issue help wanted
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Andrew-S-Rosen