Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session may be extended indefinitely #16

Open
sevdog opened this issue Jul 23, 2021 · 0 comments
Open

Session may be extended indefinitely #16

sevdog opened this issue Jul 23, 2021 · 0 comments

Comments

@sevdog
Copy link

sevdog commented Jul 23, 2021

Since qsessions uses a custom session object which is altered every time User-Agent or IP change there is a side-effect due to how base Django session engine works.

Upon save session engine changes expiry date by calling get_expiry_date (which without any arguments just extends session duration by its maximum length).

If, by any reason, a user with an active session changes User-Agent (ie: automatic updates) or IP (ie: dynamic IP) more frequently than configured session duration the session will never expire since it is saved upon every change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant