Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New argument batch_size #141

Closed
JosiahParry opened this issue Feb 3, 2024 · 1 comment · Fixed by #146
Closed

New argument batch_size #141

JosiahParry opened this issue Feb 3, 2024 · 1 comment · Fixed by #146
Labels
enhancement New feature or request

Comments

@JosiahParry
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
This argument can be used to determine the page size of requests. The current behavior is to use the maxRecordCount field as the page size. This leads to timeouts when requesting features with large quantities of features

Describe the solution you'd like

Add an argument batch_size or page_size to arc_select() which is set to NULL by default. When the value is non-null, we use that to create the all_requests object.

This signature could look like:

arc_select(
  x,
  fields = NULL,
  where = NULL,
  crs = sf::st_crs(x),
  geometry = TRUE,
  filter_geom = NULL,
  predicate = "intersects",
  n_max = Inf,
  batch_size = NULL, 
  token = arc_token(),
  ...
)

Additional context

  • should not permit an amount > maxRecordCount (emit warning in that case)
  • must be >= 1
@JosiahParry JosiahParry added the enhancement New feature or request label Feb 3, 2024
@JosiahParry
Copy link
Collaborator Author

JosiahParry commented Feb 3, 2024

Related:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant