Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Cache Github endpoint responses #249

Closed
mpgxvii opened this issue Jul 1, 2021 · 4 comments
Closed

[FEAT] Cache Github endpoint responses #249

mpgxvii opened this issue Jul 1, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request neverstale

Comments

@mpgxvii
Copy link
Member

mpgxvii commented Jul 1, 2021

Is your feature request related to a problem? Please describe.
Following #247, it would be good to cache Github responses to improve response times, avoid the rate limits, and reduce unnecessary repeated calls.

Describe the solution you'd like
As suggested by @blootsvoets and @yatharthranjan, we can use the CachedMap impl and an ExpiringMap implementation for this. Also, taking into account the maximum memory usage.

Describe alternatives you've considered
Hazelcast for caching.

Priority
5

Difficulty
6

Additional context
Supports #247

@mpgxvii mpgxvii added the enhancement New feature or request label Jul 1, 2021
@yatharthranjan
Copy link
Member

other alternatives:

  • Spring Cache: then we can use CacheManager to evict values (on memory limits). Spring Cache annotations are also compatible completely with Hazelcast so no migration needed if we move to hazelcast in the future. See more here.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 16, 2022
@stale stale bot removed the wontfix This will not be worked on label Apr 16, 2022
@yatharthranjan
Copy link
Member

@mpgxvii is this fixed with #432 ?

@mpgxvii
Copy link
Member Author

mpgxvii commented Mar 19, 2024

Fixed in #432

@mpgxvii mpgxvii closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request neverstale
Projects
None yet
Development

No branches or pull requests

2 participants