Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could convert() also downcast by default? #430

Closed
lawremi opened this issue Aug 31, 2024 · 0 comments · Fixed by #444
Closed

Could convert() also downcast by default? #430

lawremi opened this issue Aug 31, 2024 · 0 comments · Fixed by #444

Comments

@lawremi
Copy link
Collaborator

lawremi commented Aug 31, 2024

Having convert() support automatic downcasting could be an alternative to #420 for enabling constructing an object based on an instance of a parent class. I am thinking it would behave like this:

args <- props(from)
if (".data" %in% names(formals(to)))
      args$.data <- S7_data(from)
do.call(to, args[names(formals(to))], ...)

Note that the ... would allow specifying non-optional subclass properties at construction time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant