-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align query result types with rdflib #230
Comments
convert()
return SPARQLResults
for SELECT
queries?convert()
return SPARQLResult
for SELECT
queries?
convert()
return SPARQLResult
for SELECT
queries?convert()
return SPARQLResult
for SELECT
/ASK
queries?
convert()
return SPARQLResult
for SELECT
/ASK
queries?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This logic returns different representations based on the return format. I think this breaks the abstraction. The reasonable return type in this case would be rdflib's
Result
.I think the method's return type should be the same as rdflib's
Graph.query()
:so as to align querying in-memory and remote RDF sources. Or maybe the
convert
method is not required at all andquery
should returnrdflib.query.Result
.The text was updated successfully, but these errors were encountered: